From dev-return-22605-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Sat Jun 23 15:31:50 2012 Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 37C62D6EF for ; Sat, 23 Jun 2012 15:31:50 +0000 (UTC) Received: (qmail 64466 invoked by uid 500); 23 Jun 2012 15:31:49 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 64429 invoked by uid 500); 23 Jun 2012 15:31:49 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 64420 invoked by uid 99); 23 Jun 2012 15:31:49 -0000 Received: from minotaur.apache.org (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Jun 2012 15:31:49 +0000 Received: from localhost (HELO [192.168.1.5]) (127.0.0.1) (smtp-auth username rnewson, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Sat, 23 Jun 2012 15:31:49 +0000 Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Apple Message framework v1278) Subject: Re: git commit: COUCHDB-1502 - Allow user to delete own _users doc From: Robert Newson In-Reply-To: Date: Sat, 23 Jun 2012 16:31:39 +0100 Content-Transfer-Encoding: quoted-printable Message-Id: References: <20120623121539.E141F6C5A@tyr.zones.apache.org> To: dev@couchdb.apache.org X-Mailer: Apple Mail (2.1278) nope. On 23 Jun 2012, at 16:27, Jan Lehnardt wrote: >=20 > On Jun 23, 2012, at 14:15 , rnewson@apache.org wrote: >=20 >> Updated Branches: >> refs/heads/master 3bbb26127 -> f0d6f19bc >>=20 >>=20 >> COUCHDB-1502 - Allow user to delete own _users doc >=20 > Didn't we have a test for that?! > (probably my fault) >=20 >=20 >>=20 >>=20 >> Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo >> Commit: = http://git-wip-us.apache.org/repos/asf/couchdb/commit/f0d6f19b >> Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/f0d6f19b >> Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/f0d6f19b >>=20 >> Branch: refs/heads/master >> Commit: f0d6f19bc83206720df6e2eea43f378cace5b969 >> Parents: 3bbb261 >> Author: Robert Newson >> Authored: Sat Jun 23 12:08:06 2012 +0100 >> Committer: Robert Newson >> Committed: Sat Jun 23 12:46:14 2012 +0100 >>=20 >> = ---------------------------------------------------------------------- >> src/couchdb/couch_users_db.erl | 6 ++++-- >> 1 files changed, 4 insertions(+), 2 deletions(-) >> = ---------------------------------------------------------------------- >>=20 >>=20 >> = http://git-wip-us.apache.org/repos/asf/couchdb/blob/f0d6f19b/src/couchdb/c= ouch_users_db.erl >> = ---------------------------------------------------------------------- >> diff --git a/src/couchdb/couch_users_db.erl = b/src/couchdb/couch_users_db.erl >> index 6735fb6..de76142 100644 >> --- a/src/couchdb/couch_users_db.erl >> +++ b/src/couchdb/couch_users_db.erl >> @@ -104,5 +104,7 @@ after_doc_read(Doc, #db{user_ctx =3D UserCtx} =3D = Db) -> >> throw(not_found) >> end. >>=20 >> -get_doc_name(#doc{body=3D{Body}}) -> >> - couch_util:get_value(?NAME, Body). >> +get_doc_name(#doc{id=3D <<"org.couchdb.user:", Name/binary>>}) -> >> + Name; >> +get_doc_name(_) -> >> + undefined. >>=20 >=20