Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (nike.apache.org: domain of fdmanana@gmail.com designates
 209.85.160.52 as permitted sender)
MIME-Version: 1.0
Reply-To: fdmanana@gmail.com
In-Reply-To: 
 <CAJNb-9qZnR1s4hhdPkiKjFeqjnfBrt-sOyNmQtN0kKpGke1pwg@mail.gmail.com>
References: <20120425221825.0D5A2E588@tyr.zones.apache.org>
	<CAJNb-9qZnR1s4hhdPkiKjFeqjnfBrt-sOyNmQtN0kKpGke1pwg@mail.gmail.com>
Date: Thu, 26 Apr 2012 13:05:48 +0100
Message-ID: 
 <CAL3q7H6a+nB5xR9P_rUtRW-ajeeFJPTXgnvo9yq=AQ8B3fCWdw@mail.gmail.com>
Subject: Re: [2/8] git commit: Fixing the replicator_db JS test
From: Filipe David Manana <fdmanana@gmail.com>
To: dev@couchdb.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Thu, Apr 26, 2012 at 12:26 PM, Benoit Chesneau <bchesneau@gmail.com> wro=
te:
> On Thu, Apr 26, 2012 at 12:18 AM, =C2=A0<davisp@apache.org> wrote:
>> Fixing the replicator_db JS test
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/6c976bd9
>> Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/6c976bd9
>> Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/6c976bd9
>>
>> Branch: refs/heads/master
>> Commit: 6c976bd948565305c006746f449dc8cd21a749e1
>> Parents: 7d2fe95
>> Author: Paul Joseph Davis <davisp@apache.org>
>> Authored: Mon Mar 26 15:17:02 2012 -0500
>> Committer: Paul Joseph Davis <davisp@apache.org>
>> Committed: Wed Apr 25 16:54:08 2012 -0500
>>
>> ----------------------------------------------------------------------
>> =C2=A0share/www/script/test/replicator_db.js =C2=A0 =C2=A0 =C2=A0 =C2=A0=
| =C2=A0 =C2=A04 ++++
>> =C2=A0src/couch_replicator/src/couch_replicator.erl | =C2=A0 =C2=A05 +++=
+-
>> =C2=A02 files changed, 8 insertions(+), 1 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/couchdb/blob/6c976bd9/share/www/s=
cript/test/replicator_db.js
>> ----------------------------------------------------------------------
>> diff --git a/share/www/script/test/replicator_db.js b/share/www/script/t=
est/replicator_db.js
>> index 48ca341..edc85f4 100644
>> --- a/share/www/script/test/replicator_db.js
>> +++ b/share/www/script/test/replicator_db.js
>> @@ -1076,6 +1076,10 @@ couchTests.replicator_db =3D function(debug) {
>> =C2=A0 =C2=A0 });
>> =C2=A0 =C2=A0 TEquals(200, xhr.status);
>>
>> + =C2=A0 =C2=A0// Temporary band-aid, give the replicator db some
>> + =C2=A0 =C2=A0// time to make the switch
>> + =C2=A0 =C2=A0wait(500);
>> +
>> =C2=A0 =C2=A0 new_doc =3D {
>> =C2=A0 =C2=A0 =C2=A0 _id: "foo666",
>> =C2=A0 =C2=A0 =C2=A0 value: 666
>>
>> http://git-wip-us.apache.org/repos/asf/couchdb/blob/6c976bd9/src/couch_r=
eplicator/src/couch_replicator.erl
>> ----------------------------------------------------------------------
>> diff --git a/src/couch_replicator/src/couch_replicator.erl b/src/couch_r=
eplicator/src/couch_replicator.erl
>> index 1f7c08a..e91e1ae 100644
>> --- a/src/couch_replicator/src/couch_replicator.erl
>> +++ b/src/couch_replicator/src/couch_replicator.erl
>> @@ -112,7 +112,7 @@ async_replicate(#rep{id =3D {BaseId, Ext}, source =
=3D Src, target =3D Tgt} =3D Rep) ->
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 RepChildId,
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 {gen_server, start_link, [?MODULE, Rep, [{ti=
meout, Timeout}]]},
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 temporary,
>> - =C2=A0 =C2=A0 =C2=A0 =C2=A01,
>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0250,
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 worker,
>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 [?MODULE]
>> =C2=A0 =C2=A0 },
>> @@ -333,6 +333,9 @@ do_init(#rep{options =3D Options, id =3D {BaseId, Ex=
t}} =3D Rep) ->
>> =C2=A0 =C2=A0 }.
>>
>>
>> +handle_info(shutdown, St) ->
>> + =C2=A0 =C2=A0{stop, shutdown, St};
>> +
>> =C2=A0handle_info({'DOWN', Ref, _, _, Why}, #rep_state{source_monitor =
=3D Ref} =3D St) ->
>> =C2=A0 =C2=A0 ?LOG_ERROR("Source database is down. Reason: ~p", [Why]),
>> =C2=A0 =C2=A0 {stop, source_db_down, St};
>>
>
>
> Never had an issue there. What was the problem? I have the feeling it
> may be related to
>
> https://issues.apache.org/jira/browse/COUCHDB-1461

Why?

Afaik Paul's changes are to increase the shutdown time (from 1ms to
250ms) and to avoid the noisy OTP error messages when a running
replication is cancelled (shutdown handle_info clause).
However I would be highly surprised if it fixes the issue you reported.

>
> - beno=C3=AEt


--=20
Filipe David Manana,

"Reasonable men adapt themselves to the world.
=C2=A0Unreasonable men adapt the world to themselves.
=C2=A0That's why all progress depends on unreasonable men."