Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C06F89FFE for ; Wed, 21 Mar 2012 04:32:56 +0000 (UTC) Received: (qmail 31291 invoked by uid 500); 21 Mar 2012 04:32:56 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 31240 invoked by uid 500); 21 Mar 2012 04:32:55 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 31222 invoked by uid 99); 21 Mar 2012 04:32:54 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2012 04:32:54 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_NEUTRAL X-Spam-Check-By: apache.org Received-SPF: neutral (athena.apache.org: local policy) Received: from [209.85.212.52] (HELO mail-vb0-f52.google.com) (209.85.212.52) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 21 Mar 2012 04:32:50 +0000 Received: by vbzb23 with SMTP id b23so486692vbz.11 for ; Tue, 20 Mar 2012 21:32:28 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:x-gm-message-state; bh=hIVH56wJfUaMQEA4J7AoD9n80Qm9084r61O3CdRCguc=; b=ii19G2FW7k0AzDjDdGG5qjqGkPUJTDf1w0EUE/f/oW0Y+mQa7TGSNqtA0SaWhehle/ kQ20Y8wotllQxrJqv0RN3XxnZ+p03YOdKs1+6VT5AlkrKXUXBxxcDhwmvxuWEEwyFT8G nn5lOWDnJM49aoAJxTUAuj67Rx0x1qgsVgTC/MwlxWDse3OhZeLbUkpZi6aw1V7zqadd QjpuW3cR9YwQRRFh1BLtRb+SJXutzZ1nX/lp2O5r0P42VIvn6BOmjgWHvSowsD/43sy7 ZiBPjFcbn8yKGaiHDI5tYh2lJw1UzXKPTPFgcmFKwh1fiUyoKNU5nBiu46L6RNHvjU5J FqbA== Received: by 10.220.116.7 with SMTP id k7mr1233832vcq.13.1332304348059; Tue, 20 Mar 2012 21:32:28 -0700 (PDT) MIME-Version: 1.0 Received: by 10.220.156.212 with HTTP; Tue, 20 Mar 2012 21:32:07 -0700 (PDT) In-Reply-To: References: From: Jason Smith Date: Wed, 21 Mar 2012 04:32:07 +0000 Message-ID: Subject: Re: Problems blocking 1.2.0 To: dev@couchdb.apache.org Content-Type: text/plain; charset=UTF-8 X-Gm-Message-State: ALoCoQmuS1iuQmd5bGSjZwKn1/HKGf0wyum9nEq9QG7FhO18UR252z3TpYfTD5tsI+V/S2un87au X-Virus-Checked: Checked by ClamAV on apache.org Done. On Wed, Mar 21, 2012 at 4:26 AM, Paul Davis wrote: > Looks good enough to me. Something something forgiveness something permission. > > On Tue, Mar 20, 2012 at 10:40 PM, Jason Smith wrote: >> On Wed, Mar 21, 2012 at 9:54 AM, Jason Smith wrote: >>> On Wed, Mar 21, 2012 at 9:49 AM, Jason Smith wrote: >>>> The regression began at commit ede9482f. >>>> >>>> http://git-wip-us.apache.org/repos/asf?p=couchdb.git;a=commitdiff;h=ede9482fc3c9e629572ab1376d88f4499c4c8beb >>> >>> In particular, the error is with the change to couch_log.erl. >> >> Whoops. I meant couch_file.erl. >> >> Randall, please see the attached diff, or see >> http://friendpaste.com/2Hwjn9uj1oRM8pyRqAdbxc >> >> The pattern {Ref, Pid, {error, Reason}} does not match because the >> message is {Ref, Pid, Reason} >> >> I am unfamiliar with this code but I get the test suite passing with >> the change pushed to 1.2.x-couch_file. If it looks okay to someone >> more familiar with the issue, would you please merge it with 1.2.x. >> Thanks! -- Iris Couch