couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Randall Leeds <randall.le...@gmail.com>
Subject Re: Problems blocking 1.2.0
Date Wed, 21 Mar 2012 08:49:25 GMT
On Wed, Mar 21, 2012 at 01:34, Randall Leeds <randall.leeds@gmail.com>wrote:

> Thanks for cleaning up after me. Sloppy, Randall. Bad, Randall.
>

Well, I was mostly right...


> >>> In particular, the error is with the change to couch_log.erl.
>> >>
>> >> Whoops. I meant couch_file.erl.
>> >>
>> >> Randall, please see the attached diff, or see
>> >> http://friendpaste.com/2Hwjn9uj1oRM8pyRqAdbxc
>> >>
>> >> The pattern {Ref, Pid, {error, Reason}} does not match because the
>> >> message is {Ref, Pid, Reason}
>>
>
>
Only in one case, where we detect that the file exists.
I've changed it to return {error, eexist} in this case, which matches the
errors that come back from the file module in all other places and will
format the correct message.

Fixed on 1.1.x and 1.2.x.

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message