Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of bchesneau@gmail.com
 designates 209.85.215.52 as permitted sender)
Received-SPF: pass (google.com: domain of bchesneau@gmail.com designates
 10.152.102.237 as permitted sender) client-ip=10.152.102.237;
MIME-Version: 1.0
In-Reply-To: 
 <CAN-3CBJ3t9B4p17yM06ona+PViwZgG7X1v1kWYiJkT70H8PHQA@mail.gmail.com>
References: 
 <CAN-3CBJ3t9B4p17yM06ona+PViwZgG7X1v1kWYiJkT70H8PHQA@mail.gmail.com>
Date: Tue, 21 Feb 2012 01:12:58 +0100
Message-ID: 
 <CAJNb-9q8k-mvFYuueyoztXg7ybhMEf1dB_VAqg--+qzdiofOow@mail.gmail.com>
Subject: Re: Request review of CORS rewrite
From: Benoit Chesneau <bchesneau@gmail.com>
To: Jason Smith <jhs@iriscouch.com>
Cc: CouchDB Developers <dev@couchdb.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

On Mon, Feb 20, 2012 at 11:01 AM, Jason Smith <jhs@iriscouch.com> wrote:
> Hi, Benoit and devs.
>
> I am working a little bit every day on the CORS rewrite. If you could,
> would you please review the code in progress?
>
> The policy implementation is 400 LOC now and nearly complete. Features:
>
> 1. A single .erl file
> 2. Purely functional, parameterized, (uses no couch code besides
> trivial ?b2l(), couch_util, etc.)
> 3. Given a global policy, a local policy (_security object), a method,
> and list of headers, it returns the CORS response headers
> 4. For convenience, omit the global policy and we break rule 2 and
> pull it from couch_config
> 5. The local policy is also optional, since _security objects may be
> milling/degenerate.
>
> In other words, the only file worth reading is this one, but the Couch
> CORS community appreciates if you can glance at it. Maybe we can get
> the ball rolling on easy stuff like style and customs while Benoit,
> Randall and I pound out the remainder.
>
> https://github.com/jhs/couchdb/blob/newcors/src/couchdb/couch_cors_policy.erl
>
> Oh, also, I will rewrite the Git history before proposing a patchset
> so pardon the mess.
>
> Thanks!
>
> --
> Iris Couch

Thanks jason,

Sorry for the late answer, I was busy. I will have a look on it today.

- benoit