Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5604B906F for ; Wed, 29 Feb 2012 04:08:36 +0000 (UTC) Received: (qmail 15972 invoked by uid 500); 29 Feb 2012 04:08:35 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 15830 invoked by uid 500); 29 Feb 2012 04:08:33 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 15763 invoked by uid 99); 29 Feb 2012 04:08:30 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Feb 2012 04:08:30 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 29 Feb 2012 04:08:29 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 41ADA549DA for ; Wed, 29 Feb 2012 04:08:09 +0000 (UTC) Date: Wed, 29 Feb 2012 04:08:09 +0000 (UTC) From: "Jason Smith (Commented) (JIRA)" To: dev@couchdb.apache.org Message-ID: <945659747.1338.1330488489288.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1802917239.5090.1329933349086.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (COUCHDB-1416) the requested_path that is passed to a show is wrong on a vhost with a path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COUCHDB-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13218890#comment-13218890 ] Jason Smith commented on COUCHDB-1416: -------------------------------------- @Jan, would you kindly re-open this ticket (I cannot) so that Ryan can add an attachment? Thanks. @Ryan, would you please run this: git format-patch 47c81f4c25f5f9ec4ef60c4ea638d77118b9a9ee -1 And attach the 0001-Testing-*.patch file to this ticket and click the copyright agreement. > the requested_path that is passed to a show is wrong on a vhost with a path > ---------------------------------------------------------------------------- > > Key: COUCHDB-1416 > URL: https://issues.apache.org/jira/browse/COUCHDB-1416 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface > Affects Versions: 1.2 > Reporter: Ryan Ramage > Priority: Minor > Attachments: A_0001-Testing-requested_path-for-various-combinations-of-r.patch, A_0002-Compatibility-with-the-CLI-test-runner.patch, A_0003-Store-the-entire-requested-path-in-x-couchdb-vhost-f.patch, A_0004-For-a-vhost-correctly-reflect-true-requested-path.patch > > > In a show or list, it is impossible to construct a full url that an end user could use to re-request the resource, given the various combinations of vhosts and rewrites. > The major one is if the vhost contains a path component, this path information is not passed to the show at all. > I have created three tests that highlight the condition, currently failing for one test, with the two passing to prevent regressions. > The commit can be found here: > https://github.com/ryanramage/couchdb/commit/e9417480e2ce160f359d9508dcec3d4e56045a60 > I have talked this over with JasonSmith and bennoitc on #couchdb and they asked me to write the tests and raise the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira