From dev-return-21040-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Fri Feb 24 02:06:12 2012 Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id E25AA9211 for ; Fri, 24 Feb 2012 02:06:12 +0000 (UTC) Received: (qmail 45632 invoked by uid 500); 24 Feb 2012 02:06:12 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 45590 invoked by uid 500); 24 Feb 2012 02:06:12 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 45581 invoked by uid 99); 24 Feb 2012 02:06:12 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 02:06:12 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Feb 2012 02:06:09 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id F2ABE337ADA for ; Fri, 24 Feb 2012 02:05:48 +0000 (UTC) Date: Fri, 24 Feb 2012 02:05:48 +0000 (UTC) From: "Nathan Vander Wilt (Created) (JIRA)" To: dev@couchdb.apache.org Message-ID: <220689206.13169.1330049148995.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Created] (COUCHDB-1421) Wrong X-Forwarded-For address chosen as "peer"? MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org Wrong X-Forwarded-For address chosen as "peer"? ----------------------------------------------- Key: COUCHDB-1421 URL: https://issues.apache.org/jira/browse/COUCHDB-1421 Project: CouchDB Issue Type: Bug Reporter: Nathan Vander Wilt I noticed that in the Mochiweb code, it uses the last item of the X-Forward= ed-For list as the peer: https://github.com/apache/couchdb/blob/master/src/mochiweb/mochiweb_request= .erl#L82 But shouldn't this snag the *first* item of the list instead? http://tools.= ietf.org/html/draft-petersson-forwarded-for-02#section-5.2 says "the first = for-parameter will disclose the user agent where the request first was made= " =E2=80=94 the user agent is what I'd want as an app developer, not the se= cond-nearest proxy. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrato= rs: https://issues.apache.org/jira/secure/ContactAdministrators!default.jsp= a For more information on JIRA, see: http://www.atlassian.com/software/jira