From dev-return-21013-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Thu Feb 23 08:14:24 2012 Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 17E049B56 for ; Thu, 23 Feb 2012 08:14:21 +0000 (UTC) Received: (qmail 77102 invoked by uid 500); 23 Feb 2012 08:14:17 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 76985 invoked by uid 500); 23 Feb 2012 08:14:16 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 76970 invoked by uid 99); 23 Feb 2012 08:14:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2012 08:14:15 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 23 Feb 2012 08:14:09 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id E5247335CBA for ; Thu, 23 Feb 2012 08:13:48 +0000 (UTC) Date: Thu, 23 Feb 2012 08:13:48 +0000 (UTC) From: "Benoit Chesneau (Commented) (JIRA)" To: dev@couchdb.apache.org Message-ID: <1870699374.8996.1329984828939.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1802917239.5090.1329933349086.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (COUCHDB-1416) the requested_path that is passed to a show is wrong on a vhost with a path MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COUCHDB-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13214444#comment-13214444 ] Benoit Chesneau commented on COUCHDB-1416: ------------------------------------------ It is isn't possible to use the test suite to tests vhists. Since the vhost is depending on the Host header. It's unlikely that you can change it in your ajax request. I'm surprised you can't get this path since we are using it for the oauth check. Can't you use the header `x-couchdb-vhost-path` ? Anyway, the full problem right now, is that we don't pass any record while rewriting the uri. I can see 2 solutions in near future: 1. Keeping a state and sendint oit back when the mochiweb request have been modified 2. Keeping this state in the registry which was already proposed when we have to manage this step. I will have a look on it this week. > the requested_path that is passed to a show is wrong on a vhost with a path > ---------------------------------------------------------------------------- > > Key: COUCHDB-1416 > URL: https://issues.apache.org/jira/browse/COUCHDB-1416 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface > Affects Versions: 1.2 > Reporter: Ryan Ramage > Priority: Minor > > In a show or list, it is impossible to construct a full url that an end user could use to re-request the resource, given the various combinations of vhosts and rewrites. > The major one is if the vhost contains a path component, this path information is not passed to the show at all. > I have created three tests that highlight the condition, currently failing for one test, with the two passing to prevent regressions. > The commit can be found here: > https://github.com/ryanramage/couchdb/commit/e9417480e2ce160f359d9508dcec3d4e56045a60 > I have talked this over with JasonSmith and bennoitc on #couchdb and they asked me to write the tests and raise the jira. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira