couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jason Smith (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COUCHDB-1416) the requested_path that is passed to a show is wrong on a vhost with a path
Date Thu, 23 Feb 2012 09:09:50 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-1416?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Jason Smith updated COUCHDB-1416:
---------------------------------

    Attachment: A_0004-For-a-vhost-correctly-reflect-true-requested-path.patch
                A_0003-Store-the-entire-requested-path-in-x-couchdb-vhost-f.patch
                A_0002-Compatibility-with-the-CLI-test-runner.patch
                A_0001-Testing-requested_path-for-various-combinations-of-r.patch

First crack at fixing this bug. This series passes Ryan's tests and does not seem to harm
the other JS or etap tests. (I was concerned about oauth but it passed.)

My branch for this: https://github.com/jhs/couchdb/tree/COUCHDB-1416

It is based from Ryan's tests, and thus it is based on the 1.2.x branch for now.
                
> the requested_path that is passed to a show is wrong on a vhost with a path 
> ----------------------------------------------------------------------------
>
>                 Key: COUCHDB-1416
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1416
>             Project: CouchDB
>          Issue Type: Bug
>          Components: HTTP Interface
>    Affects Versions: 1.2
>            Reporter: Ryan Ramage
>            Priority: Minor
>         Attachments: A_0001-Testing-requested_path-for-various-combinations-of-r.patch,
A_0002-Compatibility-with-the-CLI-test-runner.patch, A_0003-Store-the-entire-requested-path-in-x-couchdb-vhost-f.patch,
A_0004-For-a-vhost-correctly-reflect-true-requested-path.patch
>
>
> In a show or list, it is impossible to construct a full url that an end user could use
to re-request the resource, given the various combinations of vhosts and rewrites. 
> The major one is if the vhost contains a path component, this path information is not
passed to the show at all. 
> I have created three tests that highlight the condition, currently failing for one test,
with the two passing to prevent regressions.
> The commit can be found here:
> https://github.com/ryanramage/couchdb/commit/e9417480e2ce160f359d9508dcec3d4e56045a60
> I have talked this over with JasonSmith and bennoitc on #couchdb and they asked me to
write the tests and raise the jira. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message