Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 00DFDB09A for ; Sun, 22 Jan 2012 20:58:38 +0000 (UTC) Received: (qmail 85021 invoked by uid 500); 22 Jan 2012 20:58:37 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 84974 invoked by uid 500); 22 Jan 2012 20:58:36 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 84966 invoked by uid 99); 22 Jan 2012 20:58:36 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jan 2012 20:58:36 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of paul.joseph.davis@gmail.com designates 209.85.212.52 as permitted sender) Received: from [209.85.212.52] (HELO mail-vw0-f52.google.com) (209.85.212.52) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 22 Jan 2012 20:58:31 +0000 Received: by vbbez10 with SMTP id ez10so1829034vbb.11 for ; Sun, 22 Jan 2012 12:58:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type; bh=QQ4Gj1kj4TOwX4vLssoscIBa0M/HBiXhWuJFymb1XS4=; b=FGxQ2MyMiL7mkcMDHhx2bmMkix+uGURLl5c3k8HWznDir8zsXhJWBiwzAJOqKP28CP lEGEN84J1wCu9Ubg+VQfhmtnsjktK9Q1SjSSwCxaUy+GV5sJML/LmacJAMCgC9IHpetT awV3lcOUpHivpypAlaSPpsK0qu8O9GVI7bHU4= Received: by 10.52.91.17 with SMTP id ca17mr2698945vdb.56.1327265891191; Sun, 22 Jan 2012 12:58:11 -0800 (PST) MIME-Version: 1.0 Received: by 10.220.7.208 with HTTP; Sun, 22 Jan 2012 12:57:30 -0800 (PST) In-Reply-To: References: <20120121221037.CFAF9318D76@tyr.zones.apache.org> From: Paul Davis Date: Sun, 22 Jan 2012 14:57:30 -0600 Message-ID: Subject: Re: git commit: Fix SpiderMonkey version detection To: dev@couchdb.apache.org Content-Type: text/plain; charset=ISO-8859-1 Dave confirmed. Backported to 1.1.x and 1.2.x. Sorry for the dumb mistake on that one. On Sun, Jan 22, 2012 at 2:47 PM, Paul Davis wrote: > Dave pasted me part of his. I realized that I moved the header check > above the spot where we assign the JS_CPPFLAGS which was dumb of me. > Pushed a fix in 572b561adbf852e08c7397519070f299d0b401e4 to master. > Soon as I have confirmation it's correct I'll backport to 1.2.x and > 1.1.x > > On Sun, Jan 22, 2012 at 2:38 PM, Paul Davis wrote: >> Most odd since I only added three directories to search for. >> >> Can you all post me a config.log so I can see the compiler options being used? >> >> On Sun, Jan 22, 2012 at 1:56 PM, Dave Cottlehuber wrote: >>> On 22 January 2012 19:15, Filipe David Manana wrote: >>>> Paul, after this change I'm no longer able to build master (haven't >>>> tried other branches however). >>> >>> Ditto. >>> >>>> configure can't find js/jsapi.h, this is because my jsapi.h doesn't >>>> live inside a js directory. >>>> >>>> Ubuntu 10.10 >>>> jsapi.h full path: /usr/include/xulrunner-1.9.2.24/jsapi.h >>>> >>>> flags passed to configure: >>>> >>>> configure --with-js-include=/usr/include/xulrunner-1.9.2.24 >>>> --with-js-lib=/usr/lib/xulrunner-1.9.2.24 >>> >>> Windows:: >>> /relax/js-1.8.5/js/src/dist/include/jsapi.h >>> >>> maas@sendai /relax/couchdb >>> $ more /relax/bin/couchdb_config_js185.sh >>> #!/bin/sh >>> COUCH_TOP=`pwd` >>> export COUCH_TOP >>> >>> ./configure \ >>> --with-js-lib=/relax/js-1.8.5/js/src/dist/lib \ >>> --with-js-include=/relax/js-1.8.5/js/src/dist/include \ >>> ... >>> >>> A+ >>> Dave