couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Robert Newson <rnew...@apache.org>
Subject Re: git commit: add support of erlang R15B in oauth.
Date Thu, 05 Jan 2012 16:55:41 GMT
iirc the major regression on upgrades was replacing the comparison on
secret values with one that doesn't short circuit.

On 5 January 2012 16:52, Jan Lehnardt <jan@apache.org> wrote:
> Benoit,
>
> is this a commit from the erlang-oauth project or a seperate one just for us?
>
> Are there new versions for erlang-oauth available that we should update to?
>
> In the past, we accidentally overwrote local changes when we updated versions,
> and I'm hoping to avoid that in the future :)
>
> Cheers
> Jan
> --
>
> On Jan 3, 2012, at 22:52 , benoitc@apache.org wrote:
>
>> Updated Branches:
>>  refs/heads/1.2.x 0aa0c2ae1 -> 32a3b2eb7
>>
>>
>> add support of erlang R15B in oauth.
>>
>>
>> Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
>> Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/32a3b2eb
>> Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/32a3b2eb
>> Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/32a3b2eb
>>
>> Branch: refs/heads/1.2.x
>> Commit: 32a3b2eb734fdbcc008d3460fd5937ad0e484649
>> Parents: 0aa0c2a
>> Author: benoitc <benoitc@apache.org>
>> Authored: Mon Jan 2 17:39:01 2012 +0100
>> Committer: benoitc <benoitc@apache.org>
>> Committed: Tue Jan 3 22:52:20 2012 +0100
>>
>> ----------------------------------------------------------------------
>> src/erlang-oauth/oauth_uri.erl |    2 ++
>> 1 files changed, 2 insertions(+), 0 deletions(-)
>> ----------------------------------------------------------------------
>>
>>
>> http://git-wip-us.apache.org/repos/asf/couchdb/blob/32a3b2eb/src/erlang-oauth/oauth_uri.erl
>> ----------------------------------------------------------------------
>> diff --git a/src/erlang-oauth/oauth_uri.erl b/src/erlang-oauth/oauth_uri.erl
>> index 5023f98..aebf093 100644
>> --- a/src/erlang-oauth/oauth_uri.erl
>> +++ b/src/erlang-oauth/oauth_uri.erl
>> @@ -9,6 +9,8 @@
>>
>> normalize(URI) ->
>>   case http_uri:parse(URI) of
>> +    {ok, {Scheme, UserInfo, Host, Port, Path, _Query}} -> % R15B
>> +        normalize(Scheme, UserInfo, string:to_lower(Host), Port, [Path]);
>>     {Scheme, UserInfo, Host, Port, Path, _Query} ->
>>       normalize(Scheme, UserInfo, string:to_lower(Host), Port, [Path]);
>>     Else ->
>>
>

Mime
View raw message