couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1390) Fix auth_cache etap test
Date Wed, 25 Jan 2012 17:06:40 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193122#comment-13193122
] 

Paul Joseph Davis commented on COUCHDB-1390:
--------------------------------------------

@Filipe

This assertion was the failing one:

https://github.com/apache/couchdb/blob/master/test/etap/075-auth-cache.t#L182

It was failing because the _revisions section of the document had a single revision in one
and a list of revisions in the other. If you trace the code back through the auth_cache to
couch_db:open_doc_int you'll see that the result of an open call changes depending on whether
it's passed a #doc_info{} vs a binary Id. (Ie, one keeps the entire path in _revision and
one just keeps the latest.

In the auth cache this is a difference between refreshing an entry in the cache and loading
a new entry.

As to the options to the open I just made them the same so that I didn't have to think about
possible differences between the two code paths involving those options.
                
> Fix auth_cache etap test
> ------------------------
>
>                 Key: COUCHDB-1390
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1390
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Paul Joseph Davis
>         Attachments: COUCHDB-1390.patch
>
>
> The auth_cache etap tests were failing for me. Debugged this to make sure it wasn't related
to something else. Commit message is:
>     Fix for the auth_cache etap
>     
>     As it turns out, opening a doc by id is different than opening it using
>     a #doc_info record due to the inclusion of the full revision path. This
>     ended up breaking the auth_cache tests. This way includes the entire
>     revision path for all docs and not just first doc loads.
> Patching attaching in a few moments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message