couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1390) Fix auth_cache etap test
Date Wed, 25 Jan 2012 17:28:41 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1390?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13193143#comment-13193143
] 

Filipe Manana commented on COUCHDB-1390:
----------------------------------------

Hum, then there's possibly something weird going on. I never got a failure on that test on
several machines, the tests' Creds5 and Creds9 are equal for me:

# Changing the auth database again
Creds5: [{<<"_id">>,<<"org.couchdb.user:joe">>},
         {<<"_rev">>,<<"1-bd6145e7bcacccb2c2b9811c8b40abc0">>},
         {<<"name">>,<<"joe">>},
         {<<"type">>,<<"user">>},
         {<<"salt">>,<<"SALT">>},
         {<<"password_sha">>,<<"d25de84471bb8039d73d6eab199f2c85512fb91c">>},
         {<<"roles">>,[]},
         {<<"_revisions">>,
          {[{<<"start">>,1},
            {<<"ids">>,[<<"bd6145e7bcacccb2c2b9811c8b40abc0">>]}]}}]
Creds9: [{<<"_id">>,<<"org.couchdb.user:joe">>},
         {<<"_rev">>,<<"1-bd6145e7bcacccb2c2b9811c8b40abc0">>},
         {<<"name">>,<<"joe">>},
         {<<"type">>,<<"user">>},
         {<<"salt">>,<<"SALT">>},
         {<<"password_sha">>,<<"d25de84471bb8039d73d6eab199f2c85512fb91c">>},
         {<<"roles">>,[]},
         {<<"_revisions">>,
          {[{<<"start">>,1},
            {<<"ids">>,[<<"bd6145e7bcacccb2c2b9811c8b40abc0">>]}]}}]
ok 18  - Got same credentials as before the firt auth database change

I'm concerned if there's an issue elsewhere in the test. I assumed it was very deterministic.
Can you paste the value of Creds5 and Creds9?

And the revs option is a no-op for couch_db:open_doc/3 (only meaningful for couch_doc:to_json_obj/2).
Either way adding _revisions to the credentials is not necessary (couch_query_servers:json_doc
adds it), so I would suggest the following:

http://friendpaste.com/7cZfkn6yIGGGh5CIJAawK3

thanks Paul
                
> Fix auth_cache etap test
> ------------------------
>
>                 Key: COUCHDB-1390
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1390
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Paul Joseph Davis
>         Attachments: COUCHDB-1390.patch
>
>
> The auth_cache etap tests were failing for me. Debugged this to make sure it wasn't related
to something else. Commit message is:
>     Fix for the auth_cache etap
>     
>     As it turns out, opening a doc by id is different than opening it using
>     a #doc_info record due to the inclusion of the full revision path. This
>     ended up breaking the auth_cache tests. This way includes the entire
>     revision path for all docs and not just first doc loads.
> Patching attaching in a few moments.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message