Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 54100950C for ; Sat, 10 Dec 2011 20:42:03 +0000 (UTC) Received: (qmail 40167 invoked by uid 500); 10 Dec 2011 20:42:01 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 40110 invoked by uid 500); 10 Dec 2011 20:42:01 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 40101 invoked by uid 99); 10 Dec 2011 20:42:01 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Dec 2011 20:42:01 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 10 Dec 2011 20:42:00 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 12CE310CB3A for ; Sat, 10 Dec 2011 20:41:40 +0000 (UTC) Date: Sat, 10 Dec 2011 20:41:40 +0000 (UTC) From: "Filipe Manana (Commented) (JIRA)" To: dev@couchdb.apache.org Message-ID: <1132855473.62005.1323549700078.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1900913832.31589.1319810432639.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (COUCHDB-1320) OAuth authentication doesn't work with VHost entry MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/COUCHDB-1320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166972#comment-13166972 ] Filipe Manana commented on COUCHDB-1320: ---------------------------------------- "> Why x-couchdb-vhost-path couldn't have been used for the oauth calculation ?" Not understanding your question. The changes I made to couch_httpd_oauth.erl make use of the header x-couchdb-vhost-path to compute the OAuth signature. "nm . I am just confused by the the user_ctx thing I think. Sound really overkill." Overkill in which sense? What's important is passing a user_ctx to the 2nd (post rewrite resolution) couch_httpd:handle_request_int call, so that it doesn't run all the auth handlers again. About using the process dictionary versus a new couch_httpd:handle_request_int function with an extra argument (UserCtx), I don't see any of them overkill compared to the other. > OAuth authentication doesn't work with VHost entry > -------------------------------------------------- > > Key: COUCHDB-1320 > URL: https://issues.apache.org/jira/browse/COUCHDB-1320 > Project: CouchDB > Issue Type: Bug > Components: HTTP Interface > Affects Versions: 1.1 > Environment: Ubuntu > Reporter: Martin Higham > Assignee: Filipe Manana > Fix For: 1.2 > > Attachments: Fix-OAuth-that-broke-with-vhost.patch, fdmanana-0001-Fix-OAuth-authentication-with-VHosts-URL-rewriting.patch > > > If you have a vhost entry that modifies the path (such as my host.com = /mainDB/_design/main/_rewrite ) trying to authenticate a request to this host using OAuth fails. > couch_httpd_oauth uses the modified path rather than the original x-couchdb-vhost-path when calculating the signature. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira