Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of fdmanana@gmail.com designates
 209.85.213.180 as permitted sender)
MIME-Version: 1.0
Sender: fdmanana@gmail.com
In-Reply-To: <20111109100720.E3811542C2@tyr.zones.apache.org>
References: <20111109100720.E3811542C2@tyr.zones.apache.org>
Date: Wed, 9 Nov 2011 10:51:49 +0000
Message-ID: 
 <CAL3q7H44kmAx9x4WbCTm0VJ4whqidS3Pzdr2fyZ1CgaVGufDsQ@mail.gmail.com>
Subject: Re: [5/5] git commit: fix improper comparison on filtered changes
From: Filipe David Manana <fdmanana@apache.org>
To: dev@couchdb.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Randall, which test exactly was failing in changes.js?

I've never had such failure locally. If it's due to browser caching,
it would be a good idea to add a test to test/etap/073-changes.t

On Wed, Nov 9, 2011 at 10:07 AM,  <randall@apache.org> wrote:
> fix improper comparison on filtered changes
>
> Regression caught by the changes js test.
>
>
> Project: http://git-wip-us.apache.org/repos/asf/couchdb/repo
> Commit: http://git-wip-us.apache.org/repos/asf/couchdb/commit/6213d064
> Tree: http://git-wip-us.apache.org/repos/asf/couchdb/tree/6213d064
> Diff: http://git-wip-us.apache.org/repos/asf/couchdb/diff/6213d064
>
> Branch: refs/heads/master
> Commit: 6213d064ef2467be9e6673df0fa71ffa9821ba4a
> Parents: 866769f
> Author: Randall Leeds <randall@apache.org>
> Authored: Wed Nov 9 01:16:36 2011 -0800
> Committer: Randall Leeds <randall@apache.org>
> Committed: Wed Nov 9 01:40:56 2011 -0800
>
> ----------------------------------------------------------------------
> =C2=A0src/couchdb/couch_changes.erl | =C2=A0 =C2=A02 +-
> =C2=A01 files changed, 1 insertions(+), 1 deletions(-)
> ----------------------------------------------------------------------
>
>
> http://git-wip-us.apache.org/repos/asf/couchdb/blob/6213d064/src/couchdb/=
couch_changes.erl
> ----------------------------------------------------------------------
> diff --git a/src/couchdb/couch_changes.erl b/src/couchdb/couch_changes.er=
l
> index ab95481..267f3d7 100644
> --- a/src/couchdb/couch_changes.erl
> +++ b/src/couchdb/couch_changes.erl
> @@ -328,7 +328,7 @@ send_lookup_changes(FullDocInfos, StartSeq, Dir, Db, =
Fun, Acc0) ->
> =C2=A0 =C2=A0 end,
> =C2=A0 =C2=A0 GreaterFun =3D case Dir of
> =C2=A0 =C2=A0 fwd ->
> - =C2=A0 =C2=A0 =C2=A0 =C2=A0fun(A, B) -> A >=3D B end;
> + =C2=A0 =C2=A0 =C2=A0 =C2=A0fun(A, B) -> A > B end;
> =C2=A0 =C2=A0 rev ->
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 fun(A, B) -> A =3D< B end
> =C2=A0 =C2=A0 end,
>
>


--=20
Filipe David Manana,

"Reasonable men adapt themselves to the world.
=C2=A0Unreasonable men adapt the world to themselves.
=C2=A0That's why all progress depends on unreasonable men."