Return-Path: 
 <dev-return-19060-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org>
X-Original-To: apmail-couchdb-dev-archive@www.apache.org
Delivered-To: apmail-couchdb-dev-archive@www.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 457F79E4C
	for <apmail-couchdb-dev-archive@www.apache.org>;
 Wed,  2 Nov 2011 20:51:56 +0000 (UTC)
Received: (qmail 58698 invoked by uid 500); 2 Nov 2011 20:51:55 -0000
Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org
Received: (qmail 58656 invoked by uid 500); 2 Nov 2011 20:51:55 -0000
Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:dev-help@couchdb.apache.org>
List-Unsubscribe: <mailto:dev-unsubscribe@couchdb.apache.org>
List-Post: <mailto:dev@couchdb.apache.org>
List-Id: <dev.couchdb.apache.org>
Reply-To: dev@couchdb.apache.org
Delivered-To: mailing list dev@couchdb.apache.org
Received: (qmail 58648 invoked by uid 99); 2 Nov 2011 20:51:55 -0000
Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2011 20:51:55 +0000
X-ASF-Spam-Status: No, hits=-2001.2 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 02 Nov 2011 20:51:53 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 600F532E499
	for <dev@couchdb.apache.org>; Wed,  2 Nov 2011 20:51:32 +0000 (UTC)
Date: Wed, 2 Nov 2011 20:51:32 +0000 (UTC)
From: "Noah Slater (Commented) (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Message-ID: 
 <1881319500.52592.1320267092395.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <2056983065.52347.1320264452508.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (COUCHDB-1329) couch_js/utf8.h:19:7: error: no
 newline at end of file
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394
X-Virus-Checked: Checked by ClamAV on apache.org


    [ https://issues.apache.org/jira/browse/COUCHDB-1329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142507#comment-13142507 ] 

Noah Slater commented on COUCHDB-1329:
--------------------------------------

It's better than that.

POSIX defines a text file as:

"A file that contains characters organized into zero or more lines[...]"

And a line as:

"A sequence of zero or more non- <newline> characters plus a terminating <newline> character."

And to really drive it home, it defines an incomplete line as:

"A sequence of one or more non- <newline> characters at the end of the file."

Strictly speaking, if the file does not end in a newline, it's a binary file, as far as POSIX is concerned.

Just sayin', yo.

cf. http://pubs.opengroup.org/onlinepubs/9699919799/

                
> couch_js/utf8.h:19:7: error: no newline at end of file
> ------------------------------------------------------
>
>                 Key: COUCHDB-1329
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1329
>             Project: CouchDB
>          Issue Type: Bug
>          Components: JavaScript View Server
>    Affects Versions: 1.1.1
>         Environment: likely anybody compiling with gcc -pedantic or -Werror 
>            Reporter: Dave Cottlehuber
>            Priority: Trivial
>             Fix For: 1.1.2
>
>
> ISO C 1999 requires a newline at the end of every non-blank source file:
> http://c0x.coding-guidelines.com/5.1.1.2.html vis
> "123 A source file that is not empty shall end in a new-line
> character, which shall not be immediately preceded by a backslash
> character before any such splicing takes place. "
> Thanks Mike Kimber for reporting this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira