couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results
Date Tue, 22 Nov 2011 17:48:39 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155293#comment-13155293
] 

Filipe Manana commented on COUCHDB-1289:
----------------------------------------

Bob, the thing about the "if" is that the "true" clause is not a column multiple of 4 (it's
on column 11), which violates the soft convention we have.
As for the cases, some indent the clauses to the "case" keyword, others indent it one more
level (4 spaces). I think either is readable and don't care much about it unless it starts
to be unreadable (not on 4 space multiples, of a big mix of both styles in the same module/region).
                
> heartbeats skipped when continuous changes feed filter function produces no results
> -----------------------------------------------------------------------------------
>
>                 Key: COUCHDB-1289
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1289
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Bob Dionne
>            Assignee: Bob Dionne
>            Priority: Minor
>         Attachments: 0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch
>
>
> if the changes feed has a filter function that produces no results, db_updated messages
will still be sent and the heartbeat timeout will never be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message