couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Klaus Trainer (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1321) Vars in Rewrite rules break OAuth authentication
Date Wed, 09 Nov 2011 10:23:51 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1321?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146915#comment-13146915
] 

Klaus Trainer commented on COUCHDB-1321:
----------------------------------------

> This looks like it will fix this issue and COUCHDB-1320.

Yeah, by introducing x-couchdb-requested-path and not relying on x-couchdb-vhost-path, it
should provide a fix for both the rewrite and the vhost issue.

> Does introducing x-couchdb-requested-path mean that there is no need for the vhost code
to create x-couchdb-vhost-path?

No, I don't think so as x-couchdb-vhost-path is used in src/couchdb/couch_httpd.erl and x-couchdb-requested-path
will only be set when a request is rewritten. Accordingly, x-couchdb-vhost-path will only
be set when there's a request to a vhost. Therefore, you can't replace one with the other.
                
> Vars in Rewrite rules break OAuth authentication
> ------------------------------------------------
>
>                 Key: COUCHDB-1321
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1321
>             Project: CouchDB
>          Issue Type: Bug
>          Components: HTTP Interface
>    Affects Versions: 1.1
>         Environment: Ubuntu
>            Reporter: Martin Higham
>            Priority: Minor
>         Attachments: 0001-Fix-OAuth-that-broke-with-parameters-in-rewrites.patch
>
>
> When a rewrite rule containing a var ( such as /:name/myfunction ) matches an incoming
request then an additional query param gets created. Unfortunately this new query param gets
included in the Signature Base String when the OAuth code generates its version of the request
signature to validate the incoming request it causing authentication to fail.
> To fix this isn't straightforward. When a VHost is configured there is a handy copy of
the original URL in (x-couchdb-vhost-path) that can be used to generate the Signature Base
String, unfortunately if there isn't a VHost no such copy exists.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message