couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Damien Katz (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1342) Asynchronous file writes
Date Fri, 18 Nov 2011 03:06:00 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1342?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152608#comment-13152608
] 

Damien Katz commented on COUCHDB-1342:
--------------------------------------

Paul, what I mean by "Apache users concerns" is that #3 isn't something that vanilla Apache
CouchDB users deal with, but third parties who modify the code or embed in interesting way
might (I suppose Cloudant has to deal with this). Perhaps I'm mistaken about that. I do think
patches should only be concerned with the vanilla use cases in order to be considered check-in
quality.

#4 is a style issue, not a correctness issue, or at least you haven't made a case that it's
a correctness issues. I have no problems with you changing it to a style you prefer, but we
should not expect that submitters of patches conform to an undocumented style.

There is no urgency around this patch, at Couchbase we can keep adding performance enhancements
and drift our codebase further and further from Apache. I don't want to see that happen, but
it only hurts the Apache project.

And I do see we have some culture problems in the Apache project. We need a culture where
useful, correct, fast code is verified and checked in, and then is improved incrementally.
Right now we have a culture of everyone's pet concerns must addressed before code gets checked
in, which is demoralizing and slows things down, which is a very big problem the project has
right now. I want your help in trying to change that.
                
> Asynchronous file writes
> ------------------------
>
>                 Key: COUCHDB-1342
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1342
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>            Reporter: Jan Lehnardt
>             Fix For: 1.3
>
>         Attachments: COUCHDB-1342.patch
>
>
> This change updates the file module so that it can do
> asynchronous writes. Basically it replies immediately
> to process asking to write something to the file, with
> the position where the chunks will be written to the
> file, while a dedicated child process keeps collecting
> chunks and write them to the file (and batching them
> when possible). After issuing a series of write request
> to the file module, the caller can call its 'flush'
> function which will block the caller until all the
> chunks it requested to write are effectively written
> to the file.
> This maximizes the IO subsystem, as for example, while
> the updater is traversing and modifying the btrees and
> doing CPU bound tasks, the writes are happening in
> parallel.
> Originally described at http://s.apache.org/TVu
> Github Commit: https://github.com/fdmanana/couchdb/commit/e82a673f119b82dddf674ac2e6233cd78c123554

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message