couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Dionne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results
Date Tue, 22 Nov 2011 21:50:40 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155469#comment-13155469
] 

Bob Dionne commented on COUCHDB-1289:
-------------------------------------

Filipe,

 Sorry to be dense about this, but what you describe in #2 is precisely what is happening.
`maybe_timeout` takes a boolean `Sent` which comes from the changes_sent field in the Accumulator.
It's set depending on whether or not the filter function is successful. `maybe_timeout' then
uses this to either reset the timer in the heap to now() or not depending on the timeout.

  Is is easy enough for you to extend the failing test to demo this missing case?

Thanks,

Bob

 
                
> heartbeats skipped when continuous changes feed filter function produces no results
> -----------------------------------------------------------------------------------
>
>                 Key: COUCHDB-1289
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1289
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Bob Dionne
>            Assignee: Bob Dionne
>            Priority: Minor
>         Attachments: 0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch
>
>
> if the changes feed has a filter function that produces no results, db_updated messages
will still be sent and the heartbeat timeout will never be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message