couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Dionne (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results
Date Tue, 22 Nov 2011 17:10:43 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13155261#comment-13155261
] 

Bob Dionne commented on COUCHDB-1289:
-------------------------------------

Filipe, thanks for the comments:

3. It took me a bit to figure out how this test was working at all, so I knew I could probably
simplify it further. This is better, I always forget to use  some state on the heap for these
cases.

2. I'll revisit this. I think you're saying I've missed some cases

1. Meh, this one is getting old. This indenting looks good to me. People claim to not care
too much yet keep bringing it up. The problem I have is I like to edit using modes, not manually
(which from what I can tell is how most people edit couchdb source). The other problem I have
is that the only spec I know for formatting erlang is what's in the erlang.el mode. There's
a claim about a couchdb style but this seems to vary with each committer. So I'm increasingly
reluctant to "fix" formatting when no one seems to be able to specify the rules.

Best,

Bob
                
> heartbeats skipped when continuous changes feed filter function produces no results
> -----------------------------------------------------------------------------------
>
>                 Key: COUCHDB-1289
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1289
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Bob Dionne
>            Assignee: Bob Dionne
>            Priority: Minor
>         Attachments: 0001-Ensure-heartbeats-are-not-skipped-in-continuous-chan.patch
>
>
> if the changes feed has a filter function that produces no results, db_updated messages
will still be sent and the heartbeat timeout will never be reached.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message