couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (COUCHDB-1326) scanty error message when writing to uri_file fails
Date Tue, 01 Nov 2011 16:15:32 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-1326?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Filipe Manana updated COUCHDB-1326:
-----------------------------------

    Attachment: COUCHDB-1326-fdmanana.patch

Thanks Rogutès.

I'm attaching here a patch with a few minor changes. I would like to have your feedback about
them.

1) We use indentation level of 4 spaces (you had 2 spaces);

2) Slightly changed the error message for a bit more style;

3) At this point we can use the logger and no need for io:format/2;

4) I'm catching eaccess specifically - this is a very common error and it's more user friendly
to report "file permission error" directly rather then the more cryptic eaccess - we already
do this in some places, for e.g.:  https://github.com/apache/couchdb/blob/trunk/src/couchdb/couch_config_writer.erl#L38

Let me know what you think :)
                
> scanty error message when writing to uri_file fails
> ---------------------------------------------------
>
>                 Key: COUCHDB-1326
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1326
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Rogutės Sparnuotos
>            Priority: Minor
>         Attachments: 0001-A-more-useful-error-when-writing-to-uri_file-fails.patch, 0001-A-more-useful-error-when-writing-to-uri_file-fails.patch,
COUCHDB-1326-fdmanana.patch
>
>
> CouchDB crashes when it fails writing to uri_file (set from the [couchdb] section). The
error message is too vague to understand what's going on: "{{badmatch,{error,enoent}}". At
least the filename should be mentioned.
> P.S.
> I'd say it's all Erlang's fault, because file:write_file() doesn't report the file name
on errors.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

Mime
View raw message