couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Lehnardt (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1309) File descriptor leaks on design document update and view cleanup
Date Tue, 18 Oct 2011 10:54:10 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1309?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13129658#comment-13129658
] 

Jan Lehnardt commented on COUCHDB-1309:
---------------------------------------

@Benoit, wouldn't this send a notification to every updater in every database every time a
single design doc gets updated?

I agree it is less code, but it sure sounds like a very entangled result when a ddoc in database
A changes and the updater for a ddoc in database B receives the notification. Especially in
a situation with a lot of databases (e.g. a db per user) and design docs in each.
                
> File descriptor leaks on design document update and view cleanup
> ----------------------------------------------------------------
>
>                 Key: COUCHDB-1309
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1309
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Filipe Manana
>            Assignee: Filipe Manana
>         Attachments: couchdb-1309_12x.patch, couchdb-1309_trunk.patch
>
>
> If we add a design document with views defined in it, open the corresponding view group
(by querying one of its views for e.g.), then update the design document in such a way that
the view signature changes (changing a view's map function code for e.g), the old view group
remains open forever (unless a server restart happens) and keeps it's view file reference
counter active forever.
> If a view cleanup request comes, the old view file is not deleted since the reference
counter is not dropped by the old view group, keeping the file descriptor in use forever.
> This leakage is different from what is reported in COUCHDB-1129 but it's somehow related.
> The attached patch, simply shutdowns a view group when the design document is updated
and the new view signature changes, releasing the old view file descriptor (as soon as no
more clients are using the old view).

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message