From dev-return-17964-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Tue Sep 6 08:38:47 2011 Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2B3B57230 for ; Tue, 6 Sep 2011 08:38:47 +0000 (UTC) Received: (qmail 5332 invoked by uid 500); 6 Sep 2011 08:38:45 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 4787 invoked by uid 500); 6 Sep 2011 08:38:37 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 4752 invoked by uid 99); 6 Sep 2011 08:38:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2011 08:38:34 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 06 Sep 2011 08:38:30 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id CA84982D96 for ; Tue, 6 Sep 2011 08:38:09 +0000 (UTC) Date: Tue, 6 Sep 2011 08:38:09 +0000 (UTC) From: "Robert Newson (JIRA)" To: dev@couchdb.apache.org Message-ID: <1574534089.19440.1315298289825.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <709518339.19230.1315292473276.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (COUCHDB-1271) Impossible to cancel replications in some scenarios MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COUCHDB-1271?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097806#comment-13097806 ] Robert Newson commented on COUCHDB-1271: ---------------------------------------- I like the API. I added the original "cancel":true feature and agree that it has all of the above holes. Could the two cancel_replication functions become two clauses of a single function (where user_ctx is nil in the one case)? I think that would be a little clearer since you could call cancel_replication just once in replicate/1. > Impossible to cancel replications in some scenarios > --------------------------------------------------- > > Key: COUCHDB-1271 > URL: https://issues.apache.org/jira/browse/COUCHDB-1271 > Project: CouchDB > Issue Type: Bug > Components: Replication > Reporter: Filipe Manana > Assignee: Filipe Manana > Fix For: 1.2 > > > In some scenarios it's impossible to cancel a replication by posting to /_replicate, namely: > 1) A filtered replication is started, the filter's code is updated in the source database, therefore's a subsequent cancel request will not generate the old replication ID anymore, has it got a different filter code; > 2) Dynamically changing the httpd port will also result in the impossibility of computing the right replication ID > Finally, it's also nicer for users to not need to remember the exact replication object posted before to /_replicate. > The new approach, in addition to the current approach, allows something as simple as: > POST /_replicate > {"replication_id": "0a81b645497e6270611ec3419767a584+continuous+create_target", "cancel": true} > The replication ID can be obtained from a continuous replication request's response (field "_local_id"), _active_tasks (field "replication_id") or from the log. > Aliases "_local_id" and "id" are allowed instead of "replication_id". > Patch: > https://github.com/fdmanana/couchdb/commit/c8909ea9dbcbc1f52c5c0f87e1a95102a3edfa9f.diff > (depends on COUCHDB-1266) -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira