From dev-return-17999-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Thu Sep 8 05:21:50 2011 Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id EB4107BF0 for ; Thu, 8 Sep 2011 05:21:49 +0000 (UTC) Received: (qmail 7289 invoked by uid 500); 8 Sep 2011 05:21:48 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 6216 invoked by uid 500); 8 Sep 2011 05:21:37 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 5983 invoked by uid 99); 8 Sep 2011 05:21:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2011 05:21:34 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 08 Sep 2011 05:21:31 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 3439888BE0 for ; Thu, 8 Sep 2011 05:21:10 +0000 (UTC) Date: Thu, 8 Sep 2011 05:21:10 +0000 (UTC) From: "Paul Joseph Davis (JIRA)" To: dev@couchdb.apache.org Message-ID: <1027388470.1716.1315459270210.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <2040071335.15286.1315094596986.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (COUCHDB-1270) Rewrite the view engine MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/COUCHDB-1270?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13100035#comment-13100035 ] Paul Joseph Davis commented on COUCHDB-1270: -------------------------------------------- Now that this has been on JIRA for a while I'm gonna start asking for people to raise objections to committing it. The feed back I've seen so far has been positive and the only concerns voiced are in terms of things we should look at moving forward. I'd be more than happy to wait if anyone else wants more time to review it, but I'd like to make use of this relative lull in development for this sizable of a change to land and get more widespread testing. > Rewrite the view engine > ----------------------- > > Key: COUCHDB-1270 > URL: https://issues.apache.org/jira/browse/COUCHDB-1270 > Project: CouchDB > Issue Type: Improvement > Components: JavaScript View Server > Reporter: Paul Joseph Davis > Attachments: 0001-Minor-changes-for-new-indexing-engine.patch, 0002-Create-the-couch_index-application.patch, 0003-Create-the-couch_mrview-application.patch, 0004-Remove-the-old-view-engine.patch > > > The view engine has been creaky and cluttered. As shown by GeoCouch, adding new indexers basically involves copying the entire view engine and hacking the parts that are different. In short, the opposite of good engineering. > Over the last couple weeks I've refactored the view engine and reimplemented the map/reduce view engine. These changes are 100% internal and no external behavior has changed. Performance is just a tiny bit better than trunk. I did do some playing trying to improve view update times and there are some dances we could do, but for the time being I wanted to keep the same general architecture for updates so that the changes are minimal. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira