couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Bob Dionne (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1289) heartbeats skipped when continuous changes feed filter function produces no results
Date Tue, 20 Sep 2011 08:22:09 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1289?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108432#comment-13108432
] 

Bob Dionne commented on COUCHDB-1289:
-------------------------------------

The issue in couchdb is that the timeout function is called in wait_db_updated and never triggered
if an update occurs, which is problematic when the update leads to no changes sent. I've tried
to find a minimally disruptive fix, but this is the best[1] I can do so far modulo refactoring.
I think a better solution that removes the timeout function from wait_db_updated will be the
way to go but this will be a more extensive refactoring. As an aside I think this line is
also a bug[2] and should perhaps read like the other version of changes_enumerator

[1] https://github.com/bdionne/couchdb/commit/a4d26f9b0c82c0423521cbe
[2] https://github.com/bdionne/couchdb/blob/a4d26f9b0c82c0423521cbe5a7d5f17354aa4b9a/src/couchdb/couch_changes.erl#L363

> heartbeats skipped when continuous changes feed filter function produces no results
> -----------------------------------------------------------------------------------
>
>                 Key: COUCHDB-1289
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1289
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Bob Dionne
>            Assignee: Bob Dionne
>            Priority: Minor
>
> if the changes feed has a filter function that produces no results, db_updated messages
will still be sent and the heartbeat timeout will never be reached.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message