couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Kocoloski (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (COUCHDB-954) typo in key tree logic when latest=true
Date Fri, 26 Aug 2011 02:44:29 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-954?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Adam Kocoloski resolved COUCHDB-954.
------------------------------------

       Resolution: Fixed
    Fix Version/s: 1.2

Thanks for the review.  I've committed the fix and a slightly expanded JS test to trunk. 
I didn't get around to incorporating the etap test in this ticket, but I think the JS tests
are more illustrative of the feature.

I'm inclined to not backport this patch, since replication works correctly without the optimization
and without backporting COUCHDB-953 it won't have any effect at the HTTP layer anyway.

> typo in key tree logic when latest=true
> ---------------------------------------
>
>                 Key: COUCHDB-954
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-954
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Database Core
>            Reporter: Adam Kocoloski
>            Assignee: Adam Kocoloski
>             Fix For: 1.2
>
>
> This line
> https://github.com/apache/couchdb/blob/7fe84eba9982ebb3bcaa48b7aa28fdd2e130422d/src/couchdb/couch_key_tree.erl#L195
> seems like it should read KeysToGet3 = KeysToGet2 -- LeafKeysFound, and then KeysToGet3
should be supplied to the following invocation of get_key_leafs_simple.  I think the current
code would crash if a user made an open_revs call with latest=true and a pair of revisions
that have a parent/child relationship, or at least it would crash if latest=true was implemented
(COUCHDB-953).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message