Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (nike.apache.org: domain of randall.leeds@gmail.com
 designates 209.85.214.52 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=OZKDOZBslPBw/Fg5qeu14mqhHWpz+eHUu25txPYYegk5vaRynjY5uJjBUG9l36wPLS
         r9s2pvahODX/tqiEVeYb+d6irHgh1x6B+UtEGGZQiVAfiiS1BsigT4DuVt539xVt3aXp
         3v/lM/2YkIBVj6dxAqSATYkq16KlOfNVWLDYU=
MIME-Version: 1.0
In-Reply-To: <BANLkTi=Z+x3Tdqfqp5VbOnkEr=40FWFucg@mail.gmail.com>
References: <20110608095500.7C8F52388A39@eris.apache.org>
	<BANLkTimGW19nC3vvN2CGcukLAB=UcWCywA@mail.gmail.com>
	<6B7A8FD7-78FA-4182-AAC5-AD33B16977B0@dionne-associates.com>
	<BANLkTinBs-VqWTkWML+A_eZxY-_fPJ4dJg@mail.gmail.com>
	<BANLkTi=Z+x3Tdqfqp5VbOnkEr=40FWFucg@mail.gmail.com>
Date: Wed, 8 Jun 2011 08:26:16 -0700
Message-ID: <BANLkTinYGKC+bL4XR4Q6ju5Ug3p=5LCwSA@mail.gmail.com>
Subject: Re: svn commit: r1133319 - /couchdb/trunk/src/ejson/Makefile.am
From: Randall Leeds <randall.leeds@gmail.com>
To: dev@couchdb.apache.org
Content-Type: multipart/alternative; boundary=0016e6dbe84229de3704a534f5d0

--0016e6dbe84229de3704a534f5d0
Content-Type: text/plain; charset=UTF-8

Strange.
On my machine that command includes -I for erlang includes.

Paul, that's ERLANG_FLAGS as set by configure, not ERL_FLAGS.
Does it help if you switch it to CXX or CPP? Maybe your systems are stricter
about using those variables for the .cc based stuff.

Look in that folder's generated Makefile. Does ERLANG_FLAGS have info for
finding erl_nif.h? What's that make target have for variables and does it
include the la_CFLAGS automake is supposed to have stuck in there? And does
that include ERLANG_FLAGS?

Sorry for breaking this for you. Thanks for your help.
On Jun 8, 2011 7:24 AM, "Filipe David Manana" <fdmanana@apache.org> wrote:
> Breaks my build (make dev) as well:
>
> make[3]: Entering directory `/home/fdmanana/git/hub/couchdb/src/snappy'
> /bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H
> -I. -I../.. -I../../src/snappy/google-snappy -D_XOPEN_SOURCE -g
> -O2 -MT snappy_nif.lo -MD -MP -MF .deps/snappy_nif.Tpo -c -o
> snappy_nif.lo snappy_nif.cc
> libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../..
> -I../../src/snappy/google-snappy -D_XOPEN_SOURCE -g -O2 -MT
> snappy_nif.lo -MD -MP -MF .deps/snappy_nif.Tpo -c snappy_nif.cc -fPIC
> -DPIC -o .libs/snappy_nif.o
> In file included from snappy_nif.cc:21:
> erl_nif_compat.h:27: fatal error: erl_nif.h: No such file or directory
> compilation terminated.
> make[3]: *** [snappy_nif.lo] Error 1
>
>
> On Wed, Jun 8, 2011 at 3:21 PM, Paul Davis <paul.joseph.davis@gmail.com>
wrote:
>> On Wed, Jun 8, 2011 at 10:20 AM, Robert Dionne
>> <dionne@dionne-associates.com> wrote:
>>> well it breaks my build :)
>>>
>>>
>>>
>>>
>>>
>>> On Jun 8, 2011, at 10:15 AM, Paul Davis wrote:
>>>
>>>> On Wed, Jun 8, 2011 at 5:55 AM,  <randall@apache.org> wrote:
>>>>> Author: randall
>>>>> Date: Wed Jun  8 09:55:00 2011
>>>>> New Revision: 1133319
>>>>>
>>>>> URL: http://svn.apache.org/viewvc?rev=1133319&view=rev
>>>>> Log:
>>>>> include $(ERLANG_FLAGS) when building ejson nif
>>>>>
>>>>> Modified:
>>>>>    couchdb/trunk/src/ejson/Makefile.am
>>>>>
>>>>> Modified: couchdb/trunk/src/ejson/Makefile.am
>>>>> URL:
http://svn.apache.org/viewvc/couchdb/trunk/src/ejson/Makefile.am?rev=1133319&r1=1133318&r2=1133319&view=diff
>>>>>
==============================================================================
>>>>> --- couchdb/trunk/src/ejson/Makefile.am (original)
>>>>> +++ couchdb/trunk/src/ejson/Makefile.am Wed Jun  8 09:55:00 2011
>>>>> @@ -65,6 +65,7 @@ if USE_OTP_NIFS
>>>>>  ejsonpriv_LTLIBRARIES = ejson.la
>>>>>
>>>>>  ejson_la_SOURCES = $(EJSON_C_SRCS)
>>>>> +ejson_la_CFLAGS = $(ERLANG_FLAGS)
>>>>>  ejson_la_LDFLAGS = -module -avoid-version
>>>>>
>>>>>  if WINDOWS
>>>>>
>>>>>
>>>>>
>>>>
>>>> Is this right?
>>>
>>>
>>
>> Pretty sure ERL_FLAGS is for flags for erlc which probably aren't
>> gonna go so hot for gcc. Just saying is all.
>>
>
>
>
> --
> Filipe David Manana,
> fdmanana@gmail.com, fdmanana@apache.org
>
> "Reasonable men adapt themselves to the world.
>  Unreasonable men adapt the world to themselves.
>  That's why all progress depends on unreasonable men."

--0016e6dbe84229de3704a534f5d0--