Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (nike.apache.org: domain of fdmanana@gmail.com designates
 74.125.83.180 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=vh/DBD5GvYjIZJabiT+iayB47zImcOP9Qi6zCTt/LAjP4SH4SC7QhPF4W3L9AsZ8py
         uC/zXt0h7Xw6QNLYNRhmt9MogGm3da4Q7V3CDDvwE2I615oI7J7M31WlRtQ90ENDfJrg
         1UyDjfTF5gQIzL7FPznGcq23Jbej2ZUXccYb0=
MIME-Version: 1.0
Sender: fdmanana@gmail.com
In-Reply-To: <BANLkTimE+JH0ksBxHzLxaOXFX74hmv99tQ@mail.gmail.com>
References: <BANLkTimE+JH0ksBxHzLxaOXFX74hmv99tQ@mail.gmail.com>
Date: Wed, 15 Jun 2011 10:47:27 +0100
Message-ID: <BANLkTim74wXM7Y_FATNc0BLb-HNifNnu5g@mail.gmail.com>
Subject: Re: couch_server.erl - is couch_dbs_by_name table correclty used in
 terminate() function ?
From: Filipe David Manana <fdmanana@apache.org>
To: dev@couchdb.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

It seems to me you're right about it.

Do you want to provide a small patch to fix it? (Ideally in a Jira ticket)

Thanks Andrey


On Wed, Jun 15, 2011 at 10:30 AM, Andrey Somov
<trophybase@googlemail.com> wrote:
> Hi all,
> when I read the code in couch_server.terminate() function I see the
> following in the trunk:
>
> terminate(_Reason, _Srv) ->
> =C2=A0 =C2=A0[couch_util:shutdown_sync(Pid) || {_, {Pid, _LruTime}} <-
> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0ets:tab2list(couch_dbs_by_name)]=
,
> =C2=A0 =C2=A0ok.
>
> It looks like the values in the couch_dbs_by_name table are tuples of 2
> terms.
> But when I read the rest of the code I see that the values are always
> 3-term-tuples:
>
> {opened, Pid, LruTime} or {opening, Opener, [Froms]}
>
> I must admit I do not understand how the code in the terminate() may work=
.
> Is it just a bug ?
>
>
> -
> Andrey
>


--=20
Filipe David Manana,
fdmanana@gmail.com, fdmanana@apache.org

"Reasonable men adapt themselves to the world.
=C2=A0Unreasonable men adapt the world to themselves.
=C2=A0That's why all progress depends on unreasonable men."