Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (nike.apache.org: domain of randall.leeds@gmail.com
 designates 209.85.214.52 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=glHbw7gsZyDEW+9pFK2DiQ5y2LcOohKeLJl+BLj5d6L9NmiPN4Kw1GORygkgAB8YxG
         r6sfvbgndY3vNYh+Rs/y5VN9W8w8rdvsIBxkb6MNz+cRLmvM7dqLAqUrnznmeMpj8eQJ
         hJGC01gAxiYoK1kEZEZnWYjqnp8AM1/Su4bQk=
MIME-Version: 1.0
In-Reply-To: <BANLkTike-m5ns_CPcR7SK7K4RTiPxMNrHQ@mail.gmail.com>
References: <20110608095500.7C8F52388A39@eris.apache.org>
	<BANLkTimGW19nC3vvN2CGcukLAB=UcWCywA@mail.gmail.com>
	<6B7A8FD7-78FA-4182-AAC5-AD33B16977B0@dionne-associates.com>
	<BANLkTinBs-VqWTkWML+A_eZxY-_fPJ4dJg@mail.gmail.com>
	<BANLkTi=Z+x3Tdqfqp5VbOnkEr=40FWFucg@mail.gmail.com>
	<BANLkTinYGKC+bL4XR4Q6ju5Ug3p=5LCwSA@mail.gmail.com>
	<BANLkTimcY-Lg=tXJ085_GFd8RxVuuN4=ew@mail.gmail.com>
	<BANLkTinX1+fZZgr+mcJpceCX46tb6xmprg@mail.gmail.com>
	<BANLkTinJuSANxcpUHEMHPhewCFytaTE-QQ@mail.gmail.com>
	<BANLkTimbZ=0VNP8r5cBa0wYP_68phg8pNA@mail.gmail.com>
	<BANLkTike-m5ns_CPcR7SK7K4RTiPxMNrHQ@mail.gmail.com>
Date: Wed, 8 Jun 2011 11:16:11 -0700
Message-ID: <BANLkTikY0rKR0a4RvugbaXC0XiTeVveSJA@mail.gmail.com>
Subject: Re: svn commit: r1133319 - /couchdb/trunk/src/ejson/Makefile.am
From: Randall Leeds <randall.leeds@gmail.com>
To: dev@couchdb.apache.org
Content-Type: multipart/alternative; boundary=00032555ac0acf6b7504a53754ba

--00032555ac0acf6b7504a53754ba
Content-Type: text/plain; charset=UTF-8

Read the commit log for http://svn.apache.org/viewvc?rev=1133287&view=rev
On Jun 8, 2011 10:33 AM, "Paul Davis" <paul.joseph.davis@gmail.com> wrote:
> What are all these hunks that are changing the comment syntax?
>
>
https://github.com/davisp/couchdb/commit/6ceefeb6d142b995d9a0fe578aac88105d2a0917#L2R16
>
> On Wed, Jun 8, 2011 at 12:49 PM, Paul Davis <paul.joseph.davis@gmail.com>
wrote:
>> I'm getting on a train in a few minutes. I'll go through and review
>> what you did and see if I can't figure out what's going on. May or may
>> not have internet while traveling but I should be back online in about
>> 1.5 hours.
>>
>> On Wed, Jun 8, 2011 at 12:46 PM, Randall Leeds <randall.leeds@gmail.com>
wrote:
>>> Yeah, this commit was meant to fix it when bob dionne noticed it
breaking
>>> his build, but rnewon did not. Sorry I went to sleep with a broken build
>>> there.
>>>
>>> Can you try CXX or CPP flags for that line instead and re-bootstrap?
>>> On Jun 8, 2011 8:40 AM, "Filipe David Manana" <fdmanana@apache.org>
wrote:
>>>> It happens even with a fresh checkout from git://
>>> git.apache.org/couchdb.git
>>>>
>>>> Reverting the addition of ERLANG_FLAGS to snappy's Makefile.am doesn't
>>>> help at all, so it must be one of the previous commits that touches
>>>> the autotools config (ejson builds fine however)
>>>>
>>>> On Wed, Jun 8, 2011 at 4:28 PM, Paul Davis <paul.joseph.davis@gmail.com
>
>>> wrote:
>>>>> On Wed, Jun 8, 2011 at 11:26 AM, Randall Leeds <
randall.leeds@gmail.com>
>>> wrote:
>>>>>> Strange.
>>>>>> On my machine that command includes -I for erlang includes.
>>>>>>
>>>>>> Paul, that's ERLANG_FLAGS as set by configure, not ERL_FLAGS.
>>>>>> Does it help if you switch it to CXX or CPP? Maybe your systems are
>>> stricter
>>>>>> about using those variables for the .cc based stuff.
>>>>>>
>>>>>> Look in that folder's generated Makefile. Does ERLANG_FLAGS have info
>>> for
>>>>>> finding erl_nif.h? What's that make target have for variables and
does
>>> it
>>>>>> include the la_CFLAGS automake is supposed to have stuck in there?
And
>>> does
>>>>>> that include ERLANG_FLAGS?
>>>>>>
>>>>>> Sorry for breaking this for you. Thanks for your help.
>>>>>
>>>>> Huh. Maybe everyone just needs to re-bootstrap?
>>>>>
>>>>> I haven't had a chance to get to look at it myself. I was just
>>>>> confused by ERL_FLAGS vs ERLANG_FLAGS.
>>>>>
>>>>>> On Jun 8, 2011 7:24 AM, "Filipe David Manana" <fdmanana@apache.org>
>>> wrote:
>>>>>>> Breaks my build (make dev) as well:
>>>>>>>
>>>>>>> make[3]: Entering directory
`/home/fdmanana/git/hub/couchdb/src/snappy'
>>>>>>> /bin/bash ../../libtool --tag=CXX --mode=compile g++ -DHAVE_CONFIG_H
>>>>>>> -I. -I../.. -I../../src/snappy/google-snappy -D_XOPEN_SOURCE -g
>>>>>>> -O2 -MT snappy_nif.lo -MD -MP -MF .deps/snappy_nif.Tpo -c -o
>>>>>>> snappy_nif.lo snappy_nif.cc
>>>>>>> libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../..
>>>>>>> -I../../src/snappy/google-snappy -D_XOPEN_SOURCE -g -O2 -MT
>>>>>>> snappy_nif.lo -MD -MP -MF .deps/snappy_nif.Tpo -c snappy_nif.cc
-fPIC
>>>>>>> -DPIC -o .libs/snappy_nif.o
>>>>>>> In file included from snappy_nif.cc:21:
>>>>>>> erl_nif_compat.h:27: fatal error: erl_nif.h: No such file or
directory
>>>>>>> compilation terminated.
>>>>>>> make[3]: *** [snappy_nif.lo] Error 1
>>>>>>>
>>>>>>>
>>>>>>> On Wed, Jun 8, 2011 at 3:21 PM, Paul Davis <
paul.joseph.davis@gmail.com
>>>>
>>>>>> wrote:
>>>>>>>> On Wed, Jun 8, 2011 at 10:20 AM, Robert Dionne
>>>>>>>> <dionne@dionne-associates.com> wrote:
>>>>>>>>> well it breaks my build :)
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Jun 8, 2011, at 10:15 AM, Paul Davis wrote:
>>>>>>>>>
>>>>>>>>>> On Wed, Jun 8, 2011 at 5:55 AM,  <randall@apache.org> wrote:
>>>>>>>>>>> Author: randall
>>>>>>>>>>> Date: Wed Jun  8 09:55:00 2011
>>>>>>>>>>> New Revision: 1133319
>>>>>>>>>>>
>>>>>>>>>>> URL: http://svn.apache.org/viewvc?rev=1133319&view=rev
>>>>>>>>>>> Log:
>>>>>>>>>>> include $(ERLANG_FLAGS) when building ejson nif
>>>>>>>>>>>
>>>>>>>>>>> Modified:
>>>>>>>>>>>    couchdb/trunk/src/ejson/Makefile.am
>>>>>>>>>>>
>>>>>>>>>>> Modified: couchdb/trunk/src/ejson/Makefile.am
>>>>>>>>>>> URL:
>>>>>>
>>>
http://svn.apache.org/viewvc/couchdb/trunk/src/ejson/Makefile.am?rev=1133319&r1=1133318&r2=1133319&view=diff
>>>>>>>>>>>
>>>>>>
>>>
==============================================================================
>>>>>>>>>>> --- couchdb/trunk/src/ejson/Makefile.am (original)
>>>>>>>>>>> +++ couchdb/trunk/src/ejson/Makefile.am Wed Jun  8 09:55:00 2011
>>>>>>>>>>> @@ -65,6 +65,7 @@ if USE_OTP_NIFS
>>>>>>>>>>>  ejsonpriv_LTLIBRARIES = ejson.la
>>>>>>>>>>>
>>>>>>>>>>>  ejson_la_SOURCES = $(EJSON_C_SRCS)
>>>>>>>>>>> +ejson_la_CFLAGS = $(ERLANG_FLAGS)
>>>>>>>>>>>  ejson_la_LDFLAGS = -module -avoid-version
>>>>>>>>>>>
>>>>>>>>>>>  if WINDOWS
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> Is this right?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>> Pretty sure ERL_FLAGS is for flags for erlc which probably aren't
>>>>>>>> gonna go so hot for gcc. Just saying is all.
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Filipe David Manana,
>>>>>>> fdmanana@gmail.com, fdmanana@apache.org
>>>>>>>
>>>>>>> "Reasonable men adapt themselves to the world.
>>>>>>>  Unreasonable men adapt the world to themselves.
>>>>>>>  That's why all progress depends on unreasonable men."
>>>>>>
>>>>>
>>>>
>>>>
>>>>
>>>> --
>>>> Filipe David Manana,
>>>> fdmanana@gmail.com, fdmanana@apache.org
>>>>
>>>> "Reasonable men adapt themselves to the world.
>>>>  Unreasonable men adapt the world to themselves.
>>>>  That's why all progress depends on unreasonable men."
>>>
>>

--00032555ac0acf6b7504a53754ba--