From dev-return-16569-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Wed Jun 8 15:40:54 2011 Return-Path: X-Original-To: apmail-couchdb-dev-archive@www.apache.org Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 3F36D4281 for ; Wed, 8 Jun 2011 15:40:54 +0000 (UTC) Received: (qmail 12410 invoked by uid 500); 8 Jun 2011 15:40:53 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 12363 invoked by uid 500); 8 Jun 2011 15:40:53 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 12355 invoked by uid 99); 8 Jun 2011 15:40:53 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jun 2011 15:40:53 +0000 X-ASF-Spam-Status: No, hits=-0.7 required=5.0 tests=FREEMAIL_FROM,RCVD_IN_DNSWL_LOW,RFC_ABUSE_POST,SPF_PASS,T_TO_NO_BRKTS_FREEMAIL X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of fdmanana@gmail.com designates 74.125.83.180 as permitted sender) Received: from [74.125.83.180] (HELO mail-pv0-f180.google.com) (74.125.83.180) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 08 Jun 2011 15:40:49 +0000 Received: by pvc21 with SMTP id 21so382717pvc.11 for ; Wed, 08 Jun 2011 08:40:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; bh=nJSe7gwQBMo5MssOCobE11wwVpMfxHyABOL4rpiCztM=; b=k5czn6BuD261tVOc5DMI1Nb7OQ1XbeldWcTdCNr2v7s2cFZnL6ByavIOF/DO3oa4zL Kr3Hop+VbkQQrZHT/+ayGypJnMPPYo9wNsJR9Qp6AXkVpY2y7t2YnS5wNwNADcKTnrUi UqvZMyeEgkjvpRTaOsR08Mx7QI7Oh0NNiZlDM= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type :content-transfer-encoding; b=VXWr7XrqKp0IIqYtg7IePfbG1Q2+/N4falec03zCYrKfEz8R5R1Z9lQiNET8CqDvx3 hVd9ikyukpPfSkoBNbSHVs5qPEmmoz+e/VJK1pCS3Yo8rT2o55y1sxTggU9g9l8dQ+zH /OuogboElaqsRUvmwf16GPHM59JnAWnIriZng= MIME-Version: 1.0 Received: by 10.68.21.231 with SMTP id y7mr842134pbe.493.1307547628645; Wed, 08 Jun 2011 08:40:28 -0700 (PDT) Sender: fdmanana@gmail.com Received: by 10.68.40.6 with HTTP; Wed, 8 Jun 2011 08:40:28 -0700 (PDT) In-Reply-To: References: <20110608095500.7C8F52388A39@eris.apache.org> <6B7A8FD7-78FA-4182-AAC5-AD33B16977B0@dionne-associates.com> Date: Wed, 8 Jun 2011 16:40:28 +0100 X-Google-Sender-Auth: dbOwR8n7VuXZNESKK-DiqHTkRiw Message-ID: Subject: Re: svn commit: r1133319 - /couchdb/trunk/src/ejson/Makefile.am From: Filipe David Manana To: dev@couchdb.apache.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable It happens even with a fresh checkout from git://git.apache.org/couchdb.git Reverting the addition of ERLANG_FLAGS to snappy's Makefile.am doesn't help at all, so it must be one of the previous commits that touches the autotools config (ejson builds fine however) On Wed, Jun 8, 2011 at 4:28 PM, Paul Davis wr= ote: > On Wed, Jun 8, 2011 at 11:26 AM, Randall Leeds = wrote: >> Strange. >> On my machine that command includes -I for erlang includes. >> >> Paul, that's ERLANG_FLAGS as set by configure, not ERL_FLAGS. >> Does it help if you switch it to CXX or CPP? Maybe your systems are stri= cter >> about using those variables for the .cc based stuff. >> >> Look in that folder's generated Makefile. Does ERLANG_FLAGS have info fo= r >> finding erl_nif.h? What's that make target have for variables and does i= t >> include the la_CFLAGS automake is supposed to have stuck in there? And d= oes >> that include ERLANG_FLAGS? >> >> Sorry for breaking this for you. Thanks for your help. > > Huh. Maybe everyone just needs to re-bootstrap? > > I haven't had a chance to get to look at it myself. I was just > confused by ERL_FLAGS vs ERLANG_FLAGS. > >> On Jun 8, 2011 7:24 AM, "Filipe David Manana" wrot= e: >>> Breaks my build (make dev) as well: >>> >>> make[3]: Entering directory `/home/fdmanana/git/hub/couchdb/src/snappy' >>> /bin/bash ../../libtool --tag=3DCXX --mode=3Dcompile g++ -DHAVE_CONFIG_= H >>> -I. -I../.. -I../../src/snappy/google-snappy -D_XOPEN_SOURCE -g >>> -O2 -MT snappy_nif.lo -MD -MP -MF .deps/snappy_nif.Tpo -c -o >>> snappy_nif.lo snappy_nif.cc >>> libtool: compile: g++ -DHAVE_CONFIG_H -I. -I../.. >>> -I../../src/snappy/google-snappy -D_XOPEN_SOURCE -g -O2 -MT >>> snappy_nif.lo -MD -MP -MF .deps/snappy_nif.Tpo -c snappy_nif.cc -fPIC >>> -DPIC -o .libs/snappy_nif.o >>> In file included from snappy_nif.cc:21: >>> erl_nif_compat.h:27: fatal error: erl_nif.h: No such file or directory >>> compilation terminated. >>> make[3]: *** [snappy_nif.lo] Error 1 >>> >>> >>> On Wed, Jun 8, 2011 at 3:21 PM, Paul Davis >> wrote: >>>> On Wed, Jun 8, 2011 at 10:20 AM, Robert Dionne >>>> wrote: >>>>> well it breaks my build :) >>>>> >>>>> >>>>> >>>>> >>>>> >>>>> On Jun 8, 2011, at 10:15 AM, Paul Davis wrote: >>>>> >>>>>> On Wed, Jun 8, 2011 at 5:55 AM, =C2=A0 wrote: >>>>>>> Author: randall >>>>>>> Date: Wed Jun =C2=A08 09:55:00 2011 >>>>>>> New Revision: 1133319 >>>>>>> >>>>>>> URL: http://svn.apache.org/viewvc?rev=3D1133319&view=3Drev >>>>>>> Log: >>>>>>> include $(ERLANG_FLAGS) when building ejson nif >>>>>>> >>>>>>> Modified: >>>>>>> =C2=A0 =C2=A0couchdb/trunk/src/ejson/Makefile.am >>>>>>> >>>>>>> Modified: couchdb/trunk/src/ejson/Makefile.am >>>>>>> URL: >> http://svn.apache.org/viewvc/couchdb/trunk/src/ejson/Makefile.am?rev=3D1= 133319&r1=3D1133318&r2=3D1133319&view=3Ddiff >>>>>>> >> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D >>>>>>> --- couchdb/trunk/src/ejson/Makefile.am (original) >>>>>>> +++ couchdb/trunk/src/ejson/Makefile.am Wed Jun =C2=A08 09:55:00 20= 11 >>>>>>> @@ -65,6 +65,7 @@ if USE_OTP_NIFS >>>>>>> =C2=A0ejsonpriv_LTLIBRARIES =3D ejson.la >>>>>>> >>>>>>> =C2=A0ejson_la_SOURCES =3D $(EJSON_C_SRCS) >>>>>>> +ejson_la_CFLAGS =3D $(ERLANG_FLAGS) >>>>>>> =C2=A0ejson_la_LDFLAGS =3D -module -avoid-version >>>>>>> >>>>>>> =C2=A0if WINDOWS >>>>>>> >>>>>>> >>>>>>> >>>>>> >>>>>> Is this right? >>>>> >>>>> >>>> >>>> Pretty sure ERL_FLAGS is for flags for erlc which probably aren't >>>> gonna go so hot for gcc. Just saying is all. >>>> >>> >>> >>> >>> -- >>> Filipe David Manana, >>> fdmanana@gmail.com, fdmanana@apache.org >>> >>> "Reasonable men adapt themselves to the world. >>> =C2=A0Unreasonable men adapt the world to themselves. >>> =C2=A0That's why all progress depends on unreasonable men." >> > --=20 Filipe David Manana, fdmanana@gmail.com, fdmanana@apache.org "Reasonable men adapt themselves to the world. =C2=A0Unreasonable men adapt the world to themselves. =C2=A0That's why all progress depends on unreasonable men."