couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Anderson <jch...@apache.org>
Subject Re: waitForRestart() double request()
Date Thu, 30 Jun 2011 04:45:53 GMT
On Wed, Jun 29, 2011 at 9:07 AM, Paul Davis <paul.joseph.davis@gmail.com> wrote:
> On Wed, Jun 29, 2011 at 9:45 AM, Jan Lehnardt <jan@apache.org> wrote:
>> Heya,
>>
>> I may be missing something, but our weitForRestart() function seems to have an accidental
line duplication:

That whole spot is gnarly. I did the double GET thing because it
seemed to work with it better than without it. If no one detects a
problem after removing it, then we should drop it.

Chris


>>
>> function waitForRestart() {
>>  var waiting = true;
>>  while (waiting) {
>>    try {
>>      CouchDB.request("GET", "/");
>>      CouchDB.request("GET", "/");
>>      waiting = false;
>>    } catch(e) {
>>      // the request will fail until restart completes
>>    }
>>  }
>> };
>>
>> If this is intentional, I'd like to know what the intent here is :)
>>
>> Cheers
>> Jan
>> --
>>
>>
>
> Someone's sick idea of a sleep statement?
>
> FWIW, it's been doubled up since it was committed a long time ago:
>
> https://github.com/apache/couchdb/commit/ed7e7c686fae7f1d2e3f149c2f2ed8854c4f95c8#L0R152
>



-- 
Chris Anderson
http://jchrisa.net
http://couchbase.com

Mime
View raw message