couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Alexander Shorin (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1151) Require function doesnt fullfil specification
Date Fri, 06 May 2011 19:26:03 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13030102#comment-13030102
] 

Alexander Shorin commented on COUCHDB-1151:
-------------------------------------------

No, I mean that 1075 couldn't be resolved without "id_and_require_fixes.patch". It's a two
different tasks, but they are depends from each other. If there is no practice about "one
issue ticket per one task", so sorry me and close this one(: But in this way would be relative
imports fixed? 

> Require function doesnt fullfil specification
> ---------------------------------------------
>
>                 Key: COUCHDB-1151
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1151
>             Project: CouchDB
>          Issue Type: Bug
>          Components: JavaScript View Server
>    Affects Versions: 0.11.2, 1.0.2, 1.1
>            Reporter: Alexander Shorin
>            Priority: Critical
>              Labels: commonjs, javascript, require
>         Attachments: design.require.txt, design_docs.js.patch, id_and_require_fixes.patch,
utils.js.patch
>
>   Original Estimate: 1h
>  Remaining Estimate: 1h
>
> According CommonJS Modules specification [1]:
> > 4.  Module identifiers may be "relative" or "top-level". A module identifier is
"relative" if the first term is "." or "..".
> > 5.  Top-level identifiers are resolved off the conceptual module name space root.
> This specification is broken in current realization at those terms. See design test case.
> Actually problems:
> 1. Module id is broken if module imports from same level (as via '.') or from parent
level (as via '..'). AFAIK, module id should be valid to make require(mod.id) call successful.
See`_show/relative-id`, `_show/require-relative-id` and `_show/relative-parent-id` function.
> 2. Absolute module import is broken from relative imported module. See`_show/absolute-require`
function.
> 3. Multiple relative imports from same level(as via '.') breaks require function. See
`_show/maze` function.
> Those problems makes require function works unexpectedly and obstructs solving at least
one more issue #1075 [2]
> I know that all relative imports are discouraged, but if they are supported, why they
shouldn't work properly?(:
> [1] http://wiki.commonjs.org/wiki/Modules/1.1.1
> [2] https://issues.apache.org/jira/browse/COUCHDB-1075

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message