couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Lehnardt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1103) Make vhost definitions not order-dependent, remove variable matching
Date Mon, 25 Apr 2011 13:34:09 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13024791#comment-13024791
] 

Jan Lehnardt commented on COUCHDB-1103:
---------------------------------------

@Benoit, the patch looks good.

Small nitpick: there's a debugging leftover in 160*.t

I've been working in my own version, but focussed on a different angle. Things I have in addition:

 1: 160*.t: Use proplist:is_defined instead of relying on result order and pattern matching.
 2: Half of an implementation to test http, http+https and https-only configurations.

Patch for 1: http://friendpaste.com/ElSBMc3Q2LBNMjlg1ECPw
Patch for 2 is still rough and I'm happy to delay this one in favour of getting the ticket
resolved and 1.1.0 out. I manually confirmed that the code works in all configurations.

> Make vhost definitions not order-dependent, remove variable matching
> --------------------------------------------------------------------
>
>                 Key: COUCHDB-1103
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1103
>             Project: CouchDB
>          Issue Type: Bug
>          Components: HTTP Interface
>    Affects Versions: 1.1, 1.2
>            Reporter: Jan Lehnardt
>            Assignee: Benoit Chesneau
>            Priority: Critical
>             Fix For: 1.1
>
>         Attachments: 0001-Order-results-and-make-sure-we-use-default.patch, 0001-fix-COUCHDB-1103.-Order-results-and-make-sure-we-use.patch,
0001-fix-COUCHDB-1103.-Order-results-and-make-sure-we-use.patch
>
>
> As per http://mail-archives.apache.org/mod_mbox/couchdb-dev/201103.mbox/%3cAANLkTin6zRiiFtKZoFa60DRVyOcF1dXzMYtNdKuX=ZRw@mail.gmail.com%3e
> Recording it here to not lose track.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message