couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jan Lehnardt (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (COUCHDB-1059) jquery couch list function and html response
Date Sat, 16 Apr 2011 22:24:05 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13020679#comment-13020679
] 

Jan Lehnardt commented on COUCHDB-1059:
---------------------------------------

This would be a patch:


diff --git a/share/www/script/jquery.couch.js b/share/www/script/jquery.couch.js
index 9e31cef..c62ab9e 100644
--- a/share/www/script/jquery.couch.js
+++ b/share/www/script/jquery.couch.js
@@ -1024,8 +1024,9 @@
     options = $.extend({successStatus: 200}, options);
     ajaxOptions = $.extend({contentType: "application/json"}, ajaxOptions);
     errorMessage = errorMessage || "Unknown error";
+    var dataType = options.returnType ? options.returnType : "json";
     $.ajax($.extend($.extend({
-      type: "GET", dataType: "json", cache : !$.browser.msie,
+      type: "GET", dataType: dataType, cache : !$.browser.msie,
       beforeSend: function(xhr){
         if(ajaxOptions && ajaxOptions.headers){
           for (var header in ajaxOptions.headers){
@@ -1035,7 +1036,7 @@
       },
       complete: function(req) {
         try {
-          var resp = httpData(req, "json");
+          var resp = httpData(req, dataType);
         } catch(e) {
           if (options.error) {
             options.error(req.status, req, e);


> jquery couch list function and html response
> --------------------------------------------
>
>                 Key: COUCHDB-1059
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1059
>             Project: CouchDB
>          Issue Type: Bug
>          Components: JavaScript View Server
>    Affects Versions: 1.0.1
>            Reporter: Ronen
>
> Calling a list function from jquery couch that returns a non json response (html in my
case) fails since the return type is hardcoded as json: 
>       complete: function(req) {
>         try {
>           var resp = $.httpData(req,"json");
>         } catch(e) {
>    
>       //....
> This causes httpData to try and parse the returned data as json, by making this optional
(adding returnType option to options):
>           var resp = $.httpData(req, options.returnType? options.returnType:"json");
> It is solved, 
> I can create a patch if required.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message