couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Volker Mische <volker.mis...@gmail.com>
Subject Re: [jira] Updated: (COUCHDB-1074) trouble URL rewriting for key/startkey/endkey qs params
Date Tue, 22 Mar 2011 17:29:28 GMT
Benoit,

this implies that there will be changes to the rewriter before the 1.1
release. From my understanding the 1.1.x branch is already in kind of
bug fix mode, so no new features gets added (to not delay 1.1 even
further). One could argue that COUCHDB-1074 is a bug fix, but other
rewriter features certainly not.

To conclude, I'm not sure if it should go in, before the big rewriter
rewrite or not. But it sounds sensible enough that it could go on.

Cheers,
  Volker

On 03/22/2011 03:43 AM, Benoit Chesneau wrote:
> Did anyone have time to review this patch? Especially the format
> patch? It's needed to fully complete current rewriting implementation
> before 1.1
> 
> - benoit
> 
> 
> On Sun, Mar 20, 2011 at 12:50 AM, Benoit Chesneau (JIRA)
> <jira@apache.org> wrote:
>>
>>     [ https://issues.apache.org/jira/browse/COUCHDB-1074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
>>
>> Benoit Chesneau updated COUCHDB-1074:
>> -------------------------------------
>>
>>    Attachment: 0002-add-formating-in-variables-substitution.patch
>>
>> Works with the patch:
>>  0001-fix-variable-substitutions.-handle-cases.patch
>>
>> This second patch fix formatting in variables substitutions by adding the format
member to the rewrite rule:
>>
>>    {
>>        "from": "simpleForm/basicViewPath/:start/:end",
>>        "to": "_list/simpleForm/basicView",
>>        "query": {
>>            "startkey": ":start",
>>            "endkey": ":end"
>>        },
>>        "formats": {
>>            "start": "int",
>>            "end": "int"
>>        }
>>    },
>>
>>> trouble URL rewriting for key/startkey/endkey qs params
>>> -------------------------------------------------------
>>>
>>>                 Key: COUCHDB-1074
>>>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1074
>>>             Project: CouchDB
>>>          Issue Type: Bug
>>>          Components: HTTP Interface
>>>            Reporter: Benoit Chesneau
>>>            Assignee: Benoit Chesneau
>>>              Labels: rewriter
>>>             Fix For: 1.1, 1.2
>>>
>>>         Attachments: 0001-fix-issue-COUCHDB-1074.-fix-variable-substitution.patch,
0001-fix-issue-COUCHDB-1074.-fix-variable-substitution.patch, 0001-fix-issue-COUCHDB-1074.-fix-variable-substitution.patch,
0001-fix-variable-substitutions.-handle-cases.patch, 0002-add-formating-in-variables-substitution.patch
>>>
>>>
>>> the variable substution not to happen, e.g.
>>>>
>>>> {
>>>>  "query": { "key": "\":arg\"" }
>>>> }
>>>>
>>> relative to this ml thread:
>>> http://mail-archives.apache.org/mod_mbox/couchdb-dev/201102.mbox/browser
>>
>> --
>> This message is automatically generated by JIRA.
>> For more information on JIRA, see: http://www.atlassian.com/software/jira
>>


Mime
View raw message