Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (nike.apache.org: domain of fdmanana@gmail.com designates
 209.85.161.52 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:sender:in-reply-to:references:date
         :x-google-sender-auth:message-id:subject:from:to:content-type
         :content-transfer-encoding;
        b=A3mcImnEUWcCPnadLpA51x0QBPh4mja7+PPOIeoDgF1tApp0GEDZxbe+tkWyK5WGMa
         tRTF4I70/+bcKwRUMWEDDxTjlNSu9pwnOIDM8dPwJAid6s8pdlMaQ2AP6u3QXYK0anDE
         Vc3YwR1FOroL7ERq1LeRX12ZS4r21KLoI6a10=
MIME-Version: 1.0
Sender: fdmanana@gmail.com
In-Reply-To: <AANLkTi=VXY3jbhSbaTrVrLcH1pDNGckP7riPH1mzK66F@mail.gmail.com>
References: <20110202102644.2A3062388A3C@eris.apache.org>
	<AANLkTimS2gV9u0inj3JpGr0_bcgWHxj1hy1=T2wzQMz8@mail.gmail.com>
	<AANLkTinOjGJvw2_fxEgDqCD+2tV_KWEQPRJmCwVvq5TL@mail.gmail.com>
	<AANLkTi=VXY3jbhSbaTrVrLcH1pDNGckP7riPH1mzK66F@mail.gmail.com>
Date: Wed, 2 Feb 2011 11:56:01 -0800
Message-ID: <AANLkTi=epZy-uQKSdasxNDSBq6ezHc1HssJyfnvjdNfP@mail.gmail.com>
Subject: Re: svn commit: r1066404 -
 /couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl
From: Filipe David Manana <fdmanana@apache.org>
To: dev@couchdb.apache.org
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Wed, Feb 2, 2011 at 11:37 AM, Paul Davis <paul.joseph.davis@gmail.com> w=
rote:
> when is_list_of_lists?

Right

In fact the clause [User, Pass] can also go away. Just having

[User | PassParts] -> {User, string:join(PassPartss, ":")}

should do it

>
> On Wed, Feb 2, 2011 at 2:36 PM, Robert Newson <robert.newson@gmail.com> w=
rote:
>> Ack, thanks. will fix (again)
>>
>> On Wed, Feb 2, 2011 at 7:17 PM, Filipe David Manana <fdmanana@apache.org=
> wrote:
>>> Robert,
>>>
>>>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0[User | Pass] ->
>>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0[User | Pass] when is_list(Pass) ->
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {User, string:join(Pass, ":"=
)};
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 [User] ->
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {User, ""};
>>>
>>> "Pass" will always be a list. The clause with a single element match
>>> is the redundant one. Calling string:join(":") on an emply list/string
>>> will return an empty list/string, so the [User] clause could go away.
>>>
>>> cheers
>>>
>>> On Wed, Feb 2, 2011 at 2:26 AM, =C2=A0<rnewson@apache.org> wrote:
>>>> Author: rnewson
>>>> Date: Wed Feb =C2=A02 10:26:43 2011
>>>> New Revision: 1066404
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=3D1066404&view=3Drev
>>>> Log:
>>>> fix clause warning introduced with COUCHDB-969
>>>>
>>>> Modified:
>>>> =C2=A0 =C2=A0couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl
>>>>
>>>> Modified: couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl
>>>> URL: http://svn.apache.org/viewvc/couchdb/branches/1.1.x/src/couchdb/c=
ouch_httpd_auth.erl?rev=3D1066404&r1=3D1066403&r2=3D1066404&view=3Ddiff
>>>> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D
>>>> --- couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl (original)
>>>> +++ couchdb/branches/1.1.x/src/couchdb/couch_httpd_auth.erl Wed Feb =
=C2=A02 10:26:43 2011
>>>> @@ -53,7 +53,7 @@ basic_name_pw(Req) ->
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 nil;
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 [User, Pass] ->
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {User, Pass};
>>>> - =C2=A0 =C2=A0 =C2=A0 =C2=A0[User | Pass] ->
>>>> + =C2=A0 =C2=A0 =C2=A0 =C2=A0[User | Pass] when is_list(Pass) ->
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {User, string:join(Pass, ":"=
)};
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 [User] ->
>>>> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 {User, ""};
>>>>
>>>>
>>>>
>>>
>>>
>>>
>>> --
>>> Filipe David Manana,
>>> fdmanana@gmail.com, fdmanana@apache.org
>>>
>>> "Reasonable men adapt themselves to the world.
>>> =C2=A0Unreasonable men adapt the world to themselves.
>>> =C2=A0That's why all progress depends on unreasonable men."
>>>
>>
>


--=20
Filipe David Manana,
fdmanana@gmail.com, fdmanana@apache.org

"Reasonable men adapt themselves to the world.
=C2=A0Unreasonable men adapt the world to themselves.
=C2=A0That's why all progress depends on unreasonable men."