couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-1018) trying to attach a file to a document and specifying a nonexistent revision number causes status code 500 in the HTTP response
Date Tue, 01 Feb 2011 23:46:29 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989458#comment-12989458
] 

Paul Joseph Davis commented on COUCHDB-1018:
--------------------------------------------

Minor nit on the layout of that case statement. I'd prefer something more like:

case couch_db:open_doc_revs(Db, DocId, [Rev], []) of
  {ok, [{ok, Doc0}]} -> Doc0;
  {ok, [{{not_found, missing}, Rev}]} -> throw(conflict);
  {ok, [Error]} -> throw(Error)
end

> trying to attach a file to a document and specifying a nonexistent revision number causes
status code 500 in the HTTP response
> ------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: COUCHDB-1018
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1018
>             Project: CouchDB
>          Issue Type: Bug
>          Components: HTTP Interface
>            Reporter: Klaus Trainer
>            Priority: Minor
>         Attachments: 0001-Fix-COUCHDB-1018.patch
>
>
> When trying to attach a file to a document and specifying a nonexistent revision number,
the HTTP response's status code is 500. This status code is plainly wrong, as there is definitely
no Internal Server Error in that case.
> When trying to update a document body and specifying a nonexistent revision number, the
HTTP response's status code is 409 (which is reasonable).
> Here, the resulting HTTP status codes should be consistent, i.e., independent of the
fact whether a new version of the document body or an attachment is written.

-- 
This message is automatically generated by JIRA.
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message