Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Message-ID: <2758433.355651294956765881.JavaMail.jira@thor>
Date: Thu, 13 Jan 2011 17:12:45 -0500 (EST)
From: "Adam Kocoloski (JIRA)" <jira@apache.org>
To: dev@couchdb.apache.org
Subject: [jira] Commented: (COUCHDB-1010) improve supervision tree and
 config changes reload
In-Reply-To: <19414582.108571294064565779.JavaMail.jira@thor>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/COUCHDB-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12981511#action_12981511 ] 

Adam Kocoloski commented on COUCHDB-1010:
-----------------------------------------

Sorry for the delay.  I've finished reviewing the 0001 patch.  Aside from the little whitespace error introduced in couch_db_update_notifier_sup, my only complaint is about the couch_server_sup handler.  Calling exit(whereis(couch_server_sup), shutdown) does nothing at all when the server is started by the application master (which is what happens when CouchDB is started using the shell script).  Curiously, it does shut down the server when called from the etap tests, which have a lower-level way of starting couch.

I propose we fix couch_server_sup:stop() separately because it may entail a major reworking of the etap tests.  Here's an alternative patch.  I think it's a bit more fine-grained, too, in that it only restarts couch_secondary_services, not the whole tree, when the "daemons" block changes.

https://github.com/kocolosk/couchdb/commit/1778db

> improve supervision tree and config changes reload
> --------------------------------------------------
>
>                 Key: COUCHDB-1010
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1010
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 1.2
>            Reporter: Benoit Chesneau
>            Assignee: Benoit Chesneau
>             Fix For: 1.2
>
>         Attachments: 0001-export-functions-to-couch_config.patch, 0002-another-port-from-bigcouch.-i.patch, 0002-another-port-from-bigcouch.-i.patch, 0002-another-port-from-bigcouch.-i.patch, 0003-do-like-in-other-module.-s-couch_os_daemons-MODULE.patch, COUCHDB-1010.patch
>
>
> port from bigcouch which is under apache license 2.
> - improve supervision
> - clean config changes handling.
> This has been tested in an undisclosed yet project named refuge wich is also based on couchdb but is more OTP and rebar friendly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.