couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filipe David Manana <fdman...@apache.org>
Subject Re: svn commit: r1061828 - /couchdb/trunk/src/couchdb/couch_httpd.erl
Date Fri, 21 Jan 2011 15:34:01 GMT
On Fri, Jan 21, 2011 at 3:29 PM, Benoit Chesneau <bchesneau@gmail.com> wrote:
> On Fri, Jan 21, 2011 at 4:18 PM, Filipe David Manana
> <fdmanana@apache.org> wrote:
>> -        ("httpd", "server_options") ->
>> -            ?MODULE:stop();
>>
>> Benoît, I think you forgot to add a matching clause for the new
>> couch_httpd:config_change/3 function.
>>
>
> Sound like couch_config:register handle that: (couch_config.erl line 160) .

I don't understand the reply.
What I was talking about is that you're now ignoring new values for
the "server_options" parameter. Your config_change/2 function is
missing a clause like:

config_change("httpd", "server_options") ->
    ?MODULE:stop;


>
> - benoît
>



-- 
Filipe David Manana,
fdmanana@gmail.com, fdmanana@apache.org

"Reasonable men adapt themselves to the world.
 Unreasonable men adapt the world to themselves.
 That's why all progress depends on unreasonable men."

Mime
View raw message