couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-1010) improve supervision tree and config changes reload
Date Mon, 03 Jan 2011 14:34:45 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-1010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976757#action_12976757
] 

Paul Joseph Davis commented on COUCHDB-1010:
--------------------------------------------

There are two issues being addressed by this patch that are both fine, but should probably
be in two patches so that the history is a bit more clear on what's going on.

The first issue of moving around the supervision tree is fine and looks good to me though
I'm not super knowledgeable on all the finer intricacies of OTP so I could be missing something.

The second bit has to do with only passing exported functions to couch_config. I think the
changes for this are good (though not comprehensive). But I think the parts of the patch dealing
with the config system would be better as a standalone patch. I realize that this might mean
making one patch for the config system and then moving some of that code with a second patch
for the supervision tree, but the clarity in the history would be well served by signaling
our intent here.

Also, there's a hunk that introduces a typo into the license header in couch_server_sup.erl:

-% License for the specific language governing permissions and limitations under
+% License for the specific languag governing permissions and limitations under

Other than that, LGTM.

> improve supervision tree and config changes reload
> --------------------------------------------------
>
>                 Key: COUCHDB-1010
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-1010
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 1.2
>            Reporter: Benoit Chesneau
>            Assignee: Benoit Chesneau
>             Fix For: 1.2
>
>         Attachments: COUCHDB-1010.patch
>
>
> port from bigcouch which is under apache license 2.
> - improve supervision
> - clean config changes handling.
> This has been tested in an undisclosed yet project named refuge wich is also based on
couchdb but is more OTP and rebar friendly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message