couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Adam Kocoloski (JIRA)" <>
Subject [jira] Commented: (COUCHDB-1010) improve supervision tree and config changes reload
Date Thu, 13 Jan 2011 22:12:45 GMT


Adam Kocoloski commented on COUCHDB-1010:

Sorry for the delay.  I've finished reviewing the 0001 patch.  Aside from the little whitespace
error introduced in couch_db_update_notifier_sup, my only complaint is about the couch_server_sup
handler.  Calling exit(whereis(couch_server_sup), shutdown) does nothing at all when the server
is started by the application master (which is what happens when CouchDB is started using
the shell script).  Curiously, it does shut down the server when called from the etap tests,
which have a lower-level way of starting couch.

I propose we fix couch_server_sup:stop() separately because it may entail a major reworking
of the etap tests.  Here's an alternative patch.  I think it's a bit more fine-grained, too,
in that it only restarts couch_secondary_services, not the whole tree, when the "daemons"
block changes.

> improve supervision tree and config changes reload
> --------------------------------------------------
>                 Key: COUCHDB-1010
>                 URL:
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 1.2
>            Reporter: Benoit Chesneau
>            Assignee: Benoit Chesneau
>             Fix For: 1.2
>         Attachments: 0001-export-functions-to-couch_config.patch, 0002-another-port-from-bigcouch.-i.patch,
0002-another-port-from-bigcouch.-i.patch, 0002-another-port-from-bigcouch.-i.patch, 0003-do-like-in-other-module.-s-couch_os_daemons-MODULE.patch,
> port from bigcouch which is under apache license 2.
> - improve supervision
> - clean config changes handling.
> This has been tested in an undisclosed yet project named refuge wich is also based on
couchdb but is more OTP and rebar friendly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message