couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <>
Subject [jira] Commented: (COUCHDB-1010) improve supervision tree and config changes reload
Date Mon, 03 Jan 2011 19:20:45 GMT


Paul Joseph Davis commented on COUCHDB-1010:

Why have you duplicated the code between init/1 and handle_cast/2?

Also, did you have an example for this reloading code? It doesn't look correct to me. Reading
the erl_ddll page it looks like there are quite a few ways for the driver reload to go awry
in ways that aren't warm and fuzzy. Reading through the man page and given the way we store
the port in process dicts, it looks like we should be opening the drier with the kill_ports
option and then force reloading in the try_load. Also, with the monitor option we should probably
setup a timeout to ensure that the we get the actual message back in some amount of time.

> improve supervision tree and config changes reload
> --------------------------------------------------
>                 Key: COUCHDB-1010
>                 URL:
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 1.2
>            Reporter: Benoit Chesneau
>            Assignee: Benoit Chesneau
>             Fix For: 1.2
>         Attachments: 0001-export-functions-to-couch_config.patch, 0002-another-port-from-bigcouch.-i.patch,
0002-another-port-from-bigcouch.-i.patch, 0003-do-like-in-other-module.-s-couch_os_daemons-MODULE.patch,
> port from bigcouch which is under apache license 2.
> - improve supervision
> - clean config changes handling.
> This has been tested in an undisclosed yet project named refuge wich is also based on
couchdb but is more OTP and rebar friendly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message