couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Paul Joseph Davis (JIRA)" <>
Subject [jira] Commented: (COUCHDB-1010) improve supervision tree and config changes reload
Date Mon, 03 Jan 2011 16:32:46 GMT


Paul Joseph Davis commented on COUCHDB-1010:

Looks better. For the config patch, did I already make the os daemons and httpd proxy use
the exported style?

The supervision patch looks good except that there's a bug in the config_change handler for
the ICU driver directory. It attempts to ping the driver gen_server with a reload_driver message
but the driver gen_server just ignores any info messages. Either we should just kill it and
let the supervisor restart it or alternatively give it a reload handler. If we do go with
a reload, I'd also prefer using gen_server:cast/2 instead of raw message passing for aesthetics.

Also, for the commit message in passing exported functions to couch_config, please make a
note that this is important because using anonymous functions breaks code reloading.

> improve supervision tree and config changes reload
> --------------------------------------------------
>                 Key: COUCHDB-1010
>                 URL:
>             Project: CouchDB
>          Issue Type: Improvement
>          Components: Database Core
>    Affects Versions: 1.2
>            Reporter: Benoit Chesneau
>            Assignee: Benoit Chesneau
>             Fix For: 1.2
>         Attachments: 0001-export-functions-to-couch_config.patch, 0002-another-port-from-bigcouch.-i.patch,
> port from bigcouch which is under apache license 2.
> - improve supervision
> - clean config changes handling.
> This has been tested in an undisclosed yet project named refuge wich is also based on
couchdb but is more OTP and rebar friendly.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message