Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@couchdb.apache.org
Received-SPF: pass (athena.apache.org: domain of bchesneau@gmail.com
 designates 209.85.214.180 as permitted sender)
DomainKey-Signature: a=rsa-sha1; c=nofws;
        d=gmail.com; s=gamma;
        h=mime-version:in-reply-to:references:date:message-id:subject:from:to
         :content-type;
        b=Cm+B5WrHF9WsdO30ijco9o3bhFtk/q8FZxq94GAHMpg/YPakBKldV291aRQXkvnE1r
         ns8PeKzVJrPJ7xEkQA/+2WjUWmy24gnTLgmaLENKOkAIzLs2uzNXz0WHiHMF1wyQXxq9
         eOmKAZGRhAfpxhvhd+2M71X07ZUFZGbXRgbWw=
MIME-Version: 1.0
In-Reply-To: <AANLkTi=OSueGswqveZrwQK-Ub9A+LFnXx9OHysGpxo45@mail.gmail.com>
References: <AANLkTim45jnYian4fgPRWBP72_rF-pYqK=rNw7QSChEj@mail.gmail.com>
	<AANLkTin+EQCq=pKwOSp7+39FDrHs8SWr14J7k+6w8uZG@mail.gmail.com>
	<AANLkTikULSuoXQg93he8+vAtAEEpCn58Ka9q+CYgVHNe@mail.gmail.com>
	<AANLkTinbmRVkPv1P2YnvaFSfVf6ESJnGBpNs9jX5U1V0@mail.gmail.com>
	<AANLkTi=OSueGswqveZrwQK-Ub9A+LFnXx9OHysGpxo45@mail.gmail.com>
Date: Mon, 6 Dec 2010 09:36:18 +0100
Message-ID: <AANLkTik_omsyDPo=-fLTcbAD3SZ-NXuL6A08uBTQEJCZ@mail.gmail.com>
Subject: Re: use view functions to emit changes
From: Benoit Chesneau <bchesneau@gmail.com>
To: "dev@couchdb.apache.org" <dev@couchdb.apache.org>
Content-Type: text/plain; charset=ISO-8859-1

bump.

On Tuesday, November 30, 2010, Benoit Chesneau <bchesneau@gmail.com> wrote:
> On Tue, Nov 30, 2010 at 4:44 PM, Filipe David Manana
> <fdmanana@apache.org> wrote:
>>>
>>> Here is an updated patch. It now use a filter sandbox instead of
>>> patching the function and it fixes whitespaces.
>>
>> Why a separate function to init the filter_sandbox? It can be done at
>> the end of the existing init_sandbox() function (perhaps renaming it
>> to init_sandboxes).
>>
>> I would rename Filter.filter_view to Filter.view_filter or to
>> Filter.map_filter (doing the same in
>> src/couchdb/couch_query_servers.erl for naming consistency).
>>
>> 4) is still there (the debugging ?LOG_INFO line).
>>
>> Also, this patch should only contain the changes necessary to
>> implement the new feature. While all the whitespace and indentation
>> fixes (to comply with the wiki rules) are a welcome plus, they should
>> come in a separate patch imo.
>>
> Well I used filter_view for consistency, since we use filter_docs
> already, I don't think it need to be changed at this point. I've
> removed the log stuff.
>
> Are we OK for such feature ? If yes, I will commit it.
>
> - benoit
>