From dev-return-13672-apmail-couchdb-dev-archive=couchdb.apache.org@couchdb.apache.org Fri Dec 03 11:44:51 2010 Return-Path: Delivered-To: apmail-couchdb-dev-archive@www.apache.org Received: (qmail 52351 invoked from network); 3 Dec 2010 11:44:50 -0000 Received: from unknown (HELO mail.apache.org) (140.211.11.3) by 140.211.11.9 with SMTP; 3 Dec 2010 11:44:50 -0000 Received: (qmail 91313 invoked by uid 500); 3 Dec 2010 11:44:50 -0000 Delivered-To: apmail-couchdb-dev-archive@couchdb.apache.org Received: (qmail 91188 invoked by uid 500); 3 Dec 2010 11:44:50 -0000 Mailing-List: contact dev-help@couchdb.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@couchdb.apache.org Delivered-To: mailing list dev@couchdb.apache.org Received: (qmail 91180 invoked by uid 99); 3 Dec 2010 11:44:49 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Dec 2010 11:44:49 +0000 X-ASF-Spam-Status: No, hits=0.0 required=10.0 tests= X-Spam-Check-By: apache.org Received: from [140.211.11.9] (HELO minotaur.apache.org) (140.211.11.9) by apache.org (qpsmtpd/0.29) with SMTP; Fri, 03 Dec 2010 11:44:48 +0000 Received: (qmail 52229 invoked by uid 99); 3 Dec 2010 11:44:28 -0000 Received: from localhost.apache.org (HELO [192.168.0.3]) (127.0.0.1) (smtp-auth username nslater, mechanism plain) by minotaur.apache.org (qpsmtpd/0.29) with ESMTP; Fri, 03 Dec 2010 11:44:28 +0000 Subject: Re: [jira] Commented: (COUCHDB-975) non-portable sh in configure.ac (breaks on Solaris) Mime-Version: 1.0 (Apple Message framework v1082) Content-Type: text/plain; charset=us-ascii From: Noah Slater In-Reply-To: X-Noah: Awesome Date: Fri, 3 Dec 2010 11:44:22 +0000 Content-Transfer-Encoding: quoted-printable Message-Id: References: <2894670.91201291371192823.JavaMail.jira@thor> To: dev@couchdb.apache.org X-Mailer: Apple Mail (2.1082) Haha. On 3 Dec 2010, at 11:09, Robert Dionne wrote: >=20 >=20 >=20 > On Dec 3, 2010, at 5:13 AM, Noah Slater (JIRA) wrote: >=20 >>=20 >> [ = https://issues.apache.org/jira/browse/COUCHDB-975?page=3Dcom.atlassian.jir= a.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D1296647= 1#action_12966471 ]=20 >>=20 >> Noah Slater commented on COUCHDB-975: >> ------------------------------------- >>=20 >> I'd be more comfortable with: >>=20 >> -version=3D"`${ERL} -version 2>&1 | ${SED} "s/[[^0-9]]/ /g"`"=20 >> +version=3D"`${ERL} -version 2>&1 | ${SED} 's/[[^0-9]]/ /g'`"=20 >=20 > wow, my new glasses work! I can see the diff between these two lines = :) >=20 >=20 >>=20 >> Can you confirm this would work? >>=20 >>> non-portable sh in configure.ac (breaks on Solaris) >>> --------------------------------------------------- >>>=20 >>> Key: COUCHDB-975 >>> URL: https://issues.apache.org/jira/browse/COUCHDB-975 >>> Project: CouchDB >>> Issue Type: Bug >>> Components: Build System >>> Affects Versions: 0.8, 0.8.1, 0.9, 0.9.1, 0.9.2, 0.10, 0.10.1, = 0.10.2, 0.11, 0.11.1, 0.11.2, 1.0, 1.0.1 >>> Environment: OpenSolaris (will affect other Solaris versions, = too) >>> SunOS osol-x86 5.11 snv_111b i86pc i386 i86pc Solaris >>> Reporter: Timothy Smith >>> Priority: Minor >>> Original Estimate: 0.08h >>> Remaining Estimate: 0.08h >>>=20 >>> Get this when running configure: >>> ... >>> checking for erl... /export/home/tim/c/build-couchdb/build/bin/erl >>> ./configure[12123]: : cannot execute [Is a directory] >>> /opt/csw/bin/gsed: -e expression #1, char 9: unterminated `s' = command >>> ./configure[12123]: /g: not found [No such file or directory] >>> ./configure[12125]: test: argument expected >>> ./configure[12129]: test: argument expected >>> ./configure[12133]: test: argument expected >>> checking for erlc... /export/home/tim/c/build-couchdb/build/bin/erlc >>> ... >>> A patch to fix it is: >>> commit 6b018d087ba8ddaf3789e106ade9b74488de5136 >>> Author: Timothy Smith >>> Date: Thu Dec 2 23:13:10 2010 -0700 >>> Fix syntax error with /bin/sh on Solaris >>>=20 >>> The RHS of an assignment is implicitly quoted in Bourne shell. Not >>> all shells (in particular, not /bin/sh in Solaris) can handle = nested >>> double-quotes like foo=3D"`bar "baz"`", and it's always safe to = not >>> use the outer set. >>> diff --git a/configure.ac b/configure.ac >>> index c609a08..73ea9fe 100644 >>> --- a/configure.ac >>> +++ b/configure.ac >>> @@ -243,7 +243,7 @@ fi >>>=20 >>> erlang_version_error=3D"The installed Erlang version is less than = 5.6.5 (R12B05). >>>=20 >>> -version=3D"`${ERL} -version 2>&1 | ${SED} "s/[[^0-9]]/ /g"`" >>> +version=3D`${ERL} -version 2>&1 | ${SED} "s/[[^0-9]]/ /g"` >>>=20 >>> if test `echo $version | ${AWK} "{print \\$1}"` -lt 5; then >>> AC_MSG_ERROR([$erlang_version_error]) >>=20 >> --=20 >> This message is automatically generated by JIRA. >> - >> You can reply to this email to add a comment to the issue online. >>=20 >=20