couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Lehnardt <...@apache.org>
Subject Re: [jira] Commented: (COUCHDB-980) Micro optimization to couch_file
Date Wed, 08 Dec 2010 17:32:45 GMT
FWIW,

I'd like to point out that I like this practice of creating a ticket for even small patches
with a rationale instead of simple commits. I'll try in the future to make more use of this.
Thanks for showing the way, Filipe :)

Cheers
Jan
--

On 8 Dec 2010, at 18:10, Filipe Manana (JIRA) wrote:

> 
>    [ https://issues.apache.org/jira/browse/COUCHDB-980?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12969376#action_12969376
] 
> 
> Filipe Manana commented on COUCHDB-980:
> ---------------------------------------
> 
> Committed to trunk (revision 1043524).
> 
> 
>> Micro optimization to couch_file
>> --------------------------------
>> 
>>                Key: COUCHDB-980
>>                URL: https://issues.apache.org/jira/browse/COUCHDB-980
>>            Project: CouchDB
>>         Issue Type: Improvement
>>         Components: Database Core
>>           Reporter: Filipe Manana
>>           Assignee: Filipe Manana
>> 
>> The following short patch moves the MD5 verification outside the couch_file server:
>> https://github.com/fdmanana/couchdb/commit/51c463d682c478dcb273bd88f1ef3046a709689f
>> Despite being apparently so insignificant (couch_util:md5/1 takes about 700us in
my machine), I get this significant results with relaximation:
>> $ node tests/compare_write_and_read.js --wclients 100 --rclients 200 \
>>  -name1 md5_out -name2 trunk \
>>  -url1 http://localhost:5984/ -url2 http://localhost:5985/ \
>>  --duration 120
>> run 1)  http://graphs.mikeal.couchone.com/#/graph/5c859b3e7d1b9bd0488cfe271105130c
>> run 2)  http://graphs.mikeal.couchone.com/#/graph/5c859b3e7d1b9bd0488cfe2711051bba
>> The documents used in the test have a size of about 1Kb.
>> If nobody has an objection, I'll commit this to trunk.
> 
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
> 


Mime
View raw message