couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jan Lehnardt <...@apache.org>
Subject Re: Need feedback on validate_doc_read
Date Tue, 28 Dec 2010 22:07:04 GMT
Just clearing up an aside:

On 28 Dec 2010, at 12:56, Filipe David Manana wrote:

> Overall I'm not sure this as a feature that CouchDB needs, but that's
> up to the community/PMCs to decide.

The community decides and the committers ultimately commit. The PMC helps running the project,
but doesn't dictate project future. Of course the PMC is all committers, but it is important
to understand the different hats: 

  http://www.apache.org/foundation/how-it-works.html

Cheers
Jan
-- 


> 
> Nevertheless, thanks for your efforts.
> 
> On Mon, Dec 27, 2010 at 4:09 PM, Bram Neijt <bneijt@gmail.com> wrote:
>> Hi all,
>> 
>> After getting to know erlang the hard way, I've found a place to put
>> in a patch and hook up validate_doc_read code.
>> 
>> I've got a patch which implements a validate_doc_read in the same
>> manner as validate_doc_update is implemented. The patch is available
>> at
>> https://github.com/bneijt/couchdb
>> 
>> Things that are still on the TODO are the following:
>> - Check the functioning when it comes to replication
>> - Test the performance hit this will have on the server
>> - Create a configuration option to enable or disable support for this
>> 
>> An even bigger question is: is this a feature we would ever want in
>> the mainstream couchdb releases? Is this something the couchdb team
>> would like to support?
>> 
>> But appart from that question, I would love some feedback on the
>> implementation, the erlang and structure of it all, so please consider
>> checking it out and posting some comments.
>> 
>> Greets,
>> 
>> Bram
>> 
>> 
>> On Tue, Dec 7, 2010 at 1:18 PM, Bram Neijt <bneijt@gmail.com> wrote:
>>> Dear developers,
>>> 
>>> 
>>> After going into the theoretical depths[1] of what performance hits
>>> there may be and how replication will be affected, I've decided to
>>> just implement a simple solution and see how far I can get.
>>> 
>>> I've decided to try to implement a validate_doc_get function, in the
>>> same manner as the validate_doc_update has been implemented. I've been
>>> reading the code and I've gotten as far as finding
>>> prep_and_validate_updates and handle_doc_show and I'm now thinking of
>>> copying and pasting some logic in to see where it gets me.
>>> 
>>> I would love some advice on the matter and welcome any comments/feedback.
>>> 
>>> 
>>> Greets,
>>> 
>>> Bram
>>> 
>>> [1] http://wiki.apache.org/couchdb/PerDocumentAuthorization
>>> PS If properly implemented, validate_doc_get will not fix all problems
>>> and you will still need a firewall like system, however it may give
>>> some insight into where to go from there.
>>> 
>> 
> 
> 
> 
> -- 
> Filipe David Manana,
> fdmanana@gmail.com, fdmanana@apache.org
> 
> "Reasonable men adapt themselves to the world.
>  Unreasonable men adapt the world to themselves.
>  That's why all progress depends on unreasonable men."


Mime
View raw message