couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Robert Newson (JIRA)" <j...@apache.org>
Subject [jira] Commented: (COUCHDB-997) Prevent multiple keys from entering a btree.
Date Thu, 23 Dec 2010 22:19:46 GMT

    [ https://issues.apache.org/jira/browse/COUCHDB-997?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12974772#action_12974772
] 

Robert Newson commented on COUCHDB-997:
---------------------------------------

Unless someone else chimes in, I think the usort change should go in. Yes, it will mask the
next bug that introduces duplicates but it'll get fixed before it hits the disk.

Now, if we implemented usort ourselves we could accumulate a count of the duplicates we removed,
which shouldn't be slower than usort, right?

> Prevent multiple keys from entering a btree.
> --------------------------------------------
>
>                 Key: COUCHDB-997
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-997
>             Project: CouchDB
>          Issue Type: Bug
>            Reporter: Paul Joseph Davis
>
> s/sort/usort/ at https://github.com/apache/couchdb/blob/trunk/src/couchdb/couch_btree.erl#L181
> This should be completely transparent and incur minimal overhead. This hasn't bitten
us quite yet, but it would've prevented some of the crazier behavior from COUCHDB-968

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message