couchdb-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Filipe Manana (JIRA)" <j...@apache.org>
Subject [jira] Updated: (COUCHDB-992) replicator doesn't respect .ini settings for http sources
Date Wed, 22 Dec 2010 15:55:03 GMT

     [ https://issues.apache.org/jira/browse/COUCHDB-992?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Filipe Manana updated COUCHDB-992:
----------------------------------

    Attachment: COUCHDB-992-fdmanana.patch

Looking more carefully at this, the setup of the number of http connections and pipeline size
should be done in couch_rep_httpc:db_exists/3, which is called by couch_rep:open_db/3. Conceptually
it's a more appropriate place to do it and it applies the settings either to a source or remote
database (or both).

Also, removed those settings from the #http_db record definition, to avoid setting new pipeline
values on every request the replicator sends.

I also noticed now a small typo in your patch Randall:

+        ("replicator", "max_http_piple_size", MaxPipe) ->

If nobody has an objection against the proposed patch, I'll commit it by tomorrow.

cheers



> replicator doesn't respect .ini settings for http sources
> ---------------------------------------------------------
>
>                 Key: COUCHDB-992
>                 URL: https://issues.apache.org/jira/browse/COUCHDB-992
>             Project: CouchDB
>          Issue Type: Bug
>          Components: Replication
>    Affects Versions: 1.0.1
>            Reporter: Randall Leeds
>             Fix For: 1.0.2, 1.1
>
>         Attachments: 0001-respect-replicator-config-settings-COUCHDB-992.patch, COUCHDB-992-fdmanana.patch
>
>
> The replication reader ignores the settings in the config file.
> More accurately, couch_db.hrl sets them from couch_config but then couch_rep_reader overrides
them.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message